fix(e2e): fix flaky userDetails & users spec (#26917)

* fix(e2e): fix flaky userDetails & users spec

* address gitar

(cherry picked from commit a9ad2ae)

Author: harsh-vador

openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/UserDetails.spec.ts

@@ -82,43 +82,47 @@ test.describe('User with different Roles', () => {
     await afterAction();
   });
 
-  test(
-    'Admin user can edit teams from the user profile',
-    PLAYWRIGHT_SAMPLE_DATA_TAG_OBJ,
-    async ({ adminPage }) => {
-      test.slow();
-      await redirectToUserPage(adminPage);
+  test('Admin user can edit teams from the user profile', async ({
+    adminPage,
+  }) => {
+    test.slow();
+    await visitUserProfilePage(adminPage, user1.getUserName());
 
-      // Check if the avatar is visible
-      await expect(adminPage.getByTestId('user-profile-teams')).toBeVisible();
+    // Check if the avatar is visible
+    await expect(adminPage.getByTestId('user-profile-teams')).toBeVisible();
 
-      const teamsListResponse = adminPage.waitForResponse(
-        (response) =>
-          response.url().includes('/api/v1/teams/hierarchy') &&
-          response.request().method() === 'GET'
-      );
+    const teamsListResponse = adminPage.waitForResponse(
+      (response) =>
+        response.url().includes('/api/v1/teams/hierarchy') &&
+        response.request().method() === 'GET'
+    );
 
-      await adminPage.getByTestId('edit-teams-button').click();
-      await teamsListResponse;
+    await adminPage.getByTestId('edit-teams-button').click();
+    await teamsListResponse;
 
-      await adminPage.locator('.ant-tree-select-dropdown').waitFor({
-        state: 'visible',
-      });
+    await adminPage.locator('.ant-tree-select-dropdown').waitFor({
+      state: 'visible',
+    });
 
-      const teamOption = adminPage
-        .locator('[title="' + team.responseData.displayName + '"]')
-        .first();
+    const teamOption = adminPage
+      .locator('[title="' + team.responseData.displayName + '"]')
+      .first();
 
-      await expect(teamOption).toBeVisible();
-      await teamOption.click();
+    await expect(teamOption).toBeVisible();
+    await teamOption.click();
 
-      await adminPage.getByTestId('teams-edit-save-btn').click();
+    const saveTeamsResponse = adminPage.waitForResponse(
+      (response) =>
+        response.url().includes('/api/v1/users/') &&
+        response.request().method() === 'PATCH'
+    );
 
-      await expect(adminPage.getByTestId('user-profile-teams')).toContainText(
-        team.responseData.displayName ?? team.data.displayName
-      );
-    }
-  );
+    await adminPage.getByTestId('teams-edit-save-btn').click();
+    await saveTeamsResponse;
+    await expect(adminPage.getByTestId('user-profile-teams')).toContainText(
+      team.responseData.displayName ?? team.data.displayName
+    );
+  });
 
   test('Create team with domain and verify visibility of inherited domain in user profile after team removal', async ({
     adminPage,

openmetadata-ui/src/main/resources/ui/playwright/utils/user.ts

@@ -707,8 +707,10 @@ export const addUser = async (
     personas?: string[];
   }
 ) => {
+  await waitForAllLoadersToDisappear(page);
   await page.click('[data-testid="add-user"]');
 
+  await page.waitForResponse('/api/v1/roles?default=false&limit=100&fields=');
   await page.fill('[data-testid="email"]', email);
 
   await page.fill('[data-testid="displayName"]', name);