Revert RecordThread to integrate file opening into run method

Author: anjaldoshi

Source/Processors/RecordNode/RecordNode.cpp

@@ -928,7 +928,6 @@ void RecordNode::startRecording()
     }
 
     recordThread->setFileComponents (rootFolder, experimentNumber, recordingNumber);
-    recordThread->openFiles();
     recordThread->startThread (Thread::Priority::highest);
 
     if (settingsNeeded)

Source/Processors/RecordNode/RecordThread.cpp

@@ -96,8 +96,12 @@ void RecordThread::setFirstBlockFlag (bool state)
     this->notify();
 }
 
-void RecordThread::openFiles()
+void RecordThread::run()
 {
+    // Initialize counters
+    spikesReceived = 0;
+    spikesWritten = 0;
+
     // Initialize per-channel sample numbers
     sampleNumbers.clear();
     for (int chan = 0; chan < m_numChannels; ++chan)
@@ -111,23 +115,15 @@ void RecordThread::openFiles()
     m_perStreamTimestampIdxs.resize (numStreams);
     m_perStreamSampleNumbers.resize (numStreams, 0);
 
+    // 1 - Open files
+    bool closeEarly = false;
+    m_cleanExit = false;
+    Array<int64> initSampleNumbers;
+
     m_engine->openFiles (m_rootFolder, m_experimentNumber, m_recordingNumber);
 
     if (recordNode != nullptr)
         recordNode->notifyRecordThreadFilesOpened();
-}
-
-void RecordThread::run()
-{
-    // 1-Initialize counters
-    spikesReceived = 0;
-    spikesWritten = 0;
-
-    bool closeEarly = false;
-    int numStreams = recordNode->getNumDataStreams();
-
-    m_cleanExit = false;
-    Array<int64> initSampleNumbers;
 
     //2-Wait until the first block has arrived, so we can align the timestamps
     bool isWaiting = false;

Source/Processors/RecordNode/RecordThread.h

@@ -72,9 +72,6 @@ class RecordThread : public Thread
     /** Sets the pointers to the data queues (one per stream), event queue, and spike queue */
     void setQueuePointers (OwnedArray<DataQueue>* dataQueues, EventMsgQueue* events, SpikeMsgQueue* spikes);
 
-    /** Opens files prior to starting recording */
-    void openFiles();
-
     /** Runs the thread */
     void run() override;