Skip to content

Commit 98e02f6

Browse files
committed
Prevent parenthesis from corrupting settings files
1 parent 5fa03a0 commit 98e02f6

2 files changed

Lines changed: 7 additions & 1 deletion

File tree

Source/MainWindow.cpp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -398,6 +398,12 @@ bool MainWindow::compareConfigFiles(File file1, File file2)
398398
return true;
399399
}
400400

401+
if (lcXml == 0 || !lcXml->hasTagName("SETTINGS"))
402+
{
403+
LOGD("Last config is invalid. Loading recoveryConfig.xml");
404+
return false;
405+
}
406+
401407
auto lcSig = lcXml->getChildByName("SIGNALCHAIN");
402408
auto rcSig = rcXml->getChildByName("SIGNALCHAIN");
403409

Source/UI/EditorViewport.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1469,7 +1469,7 @@ std::unique_ptr<XmlElement> EditorViewport::createSettingsXml()
14691469

14701470
for (auto editor : editorArray)
14711471
{
1472-
XmlElement* visibleEditorXml = new XmlElement(editor->getName().replaceCharacters(" ","_").toUpperCase());
1472+
XmlElement* visibleEditorXml = new XmlElement(editor->getName().replaceCharacters(" ()","___").toUpperCase());
14731473
visibleEditorXml->setAttribute("ID", editor->getProcessor()->getNodeId());
14741474
editorViewportSettings->addChildElement(visibleEditorXml);
14751475
}

0 commit comments

Comments
 (0)