Restore calls to refreshState() for Visualizers in tabs

Author: jsiegle

Plugins/LfpDisplayNode/LfpDisplayCanvas.cpp

@@ -295,11 +295,6 @@ void LfpDisplayCanvas::update()
 void LfpDisplayCanvas::refreshState()
 {
 
-    for (auto split : displaySplits)
-    {
-        split->refreshSplitterState();
-    }
-
 }
 
 void LfpDisplayCanvas::select(LfpDisplaySplitter* splitter)

Source/UI/DataViewport.cpp

@@ -55,8 +55,6 @@ int DataViewport::addTabToDataViewport(String name,
 
     addTab(name, Colours::lightgrey, component, false, tabIndex);
 
-    getTabbedButtonBar().setCurrentTabIndex(tabIndex);
-
     getTabbedButtonBar().setTabBackgroundColour(tabIndex, Colours::darkgrey);
 
     setOutline(0);
@@ -94,7 +92,7 @@ void DataViewport::destroyTab(int index)
 
     tabArray.remove(newIndex);
     tabIndex--;
-    
+
     removeTab(newIndex);
 
     if (tabArray.size() == 0)
@@ -141,11 +139,17 @@ void DataViewport::disableConnectionToEditorViewport()
 
 void DataViewport::currentTabChanged(int newIndex, const String& newTabName)
 {
-    LOGDD("Data Viewport current tab changed; newIndex = ", newIndex);
+    LOGD("Data Viewport current tab changed; newIndex = ", newIndex);
 
     if (!shutdown)
     {
-        getTopLevelComponent()->repaint();
+
+        if (getTabContentComponent(newIndex) != nullptr)
+        {
+            LOGD("Refreshing state for ", newTabName);
+            Visualizer* v = (Visualizer*)getTabContentComponent(newIndex);
+            v->refreshState();
+        }
     }
 }
 

Source/UI/GraphViewer.h

@@ -26,6 +26,7 @@
 
 #include "../AccessClass.h"
 #include "../Processors/Editors/GenericEditor.h"
+#include "../Processors/Visualization/Visualizer.h"
 
 #include "../../JuceLibraryCode/JuceHeader.h"
 
@@ -108,7 +109,7 @@ class GraphNode : public Component,
 
     /** Paint component */
     void paint (Graphics& g)    override;
-    
+
     /** Behavior on start of mouse hover */
     void mouseEnter (const MouseEvent& event) override;
 
@@ -198,7 +199,7 @@ class GraphNode : public Component,
     Allows the GraphViewer to be scrolled
 
  */
-class GraphViewport : public Component
+class GraphViewport : public Visualizer
 {
 public:
     /** Constructor */
@@ -210,6 +211,11 @@ class GraphViewport : public Component
     /** Draws the Open Ephys Logo*/
     void paint(Graphics& g) override;
 
+    /** Visualizer virtual functions */
+    void refresh() { }
+    void update() { }
+    void refreshState() { }
+
     /** Sets viewport bounds*/
     void resized() override;
 

Source/UI/InfoLabel.h

@@ -27,6 +27,8 @@
 
 #include "../../JuceLibraryCode/JuceHeader.h"
 
+#include "../Processors/Visualization/Visualizer.h"
+
 /**
 
   Makes it possible to switch between different tabs
@@ -56,7 +58,7 @@ class InfoLabelTabButton : public Button
 
 */
 
-class InfoLabel : public Component,
+class InfoLabel : public Visualizer,
     public Button::Listener
 
 {
@@ -70,6 +72,11 @@ class InfoLabel : public Component,
     /** Fills the background and draws a logo.*/
     void paint(Graphics& g);
 
+    /** Visualizer virtual functions */
+    void refresh() { }
+    void update() { }
+    void refreshState() { }
+
     /** Resizes text field*/
     void resized();