Optimize RecordNode::startRecording logic

Author: anjaldoshi

Source/Processors/RecordNode/RecordNode.cpp

@@ -791,7 +791,6 @@ bool RecordNode::stopAcquisition()
 // called by GenericProcessor::setRecording() and CoreServices::setRecordingStatus()
 void RecordNode::startRecording()
 {
-    
     Array<int> chanProcessorMap;
     Array<int> chanOrderinProc;
     OwnedArray<RecordProcessorInfo> procInfo;
@@ -878,7 +877,7 @@ void RecordNode::startRecording()
         {
             DataQueue* queue = new DataQueue (bufferSize, DATA_BUFFER_NBLOCKS);
             queue->setChannelCount (recordedChannelsPerStream[i]);
-            queue->setTimestampStreamCount (1);  // Each queue has one timestamp stream
+            queue->setTimestampStreamCount (1); // Each queue has one timestamp stream
             dataQueues.add (queue);
 
             // Pre-compute source channel array for this stream
@@ -929,8 +928,7 @@ void RecordNode::startRecording()
     }
 
     recordThread->setFileComponents (rootFolder, experimentNumber, recordingNumber);
-    recordThread->startThread(Thread::Priority::highest);
-    isRecording = true;
+    recordThread->startThread (Thread::Priority::highest);
 
     if (settingsNeeded)
     {
@@ -946,6 +944,14 @@ void RecordNode::startRecording()
     }
 }
 
+void RecordNode::notifyRecordThreadFilesOpened()
+{
+    MessageManager::callAsync ([this]()
+                               {
+                                   if (recordThread->isThreadRunning())
+                                       isRecording = true; });
+}
+
 // called by GenericProcessor::setRecording() and CoreServices::setRecordingStatus()
 void RecordNode::stopRecording()
 {
@@ -1155,7 +1161,7 @@ void RecordNode::process (AudioBuffer<float>& buffer)
                 dataQueues[streamIndex]->writeSynchronizedTimestamps (
                     first,
                     second - first,
-                    0,  // timestamp stream index within this queue
+                    0, // timestamp stream index within this queue
                     numSamples);
             }
 

Source/Processors/RecordNode/RecordNode.h

@@ -140,6 +140,9 @@ class TESTABLE RecordNode : public GenericProcessor,
     /* Called at start of recording; launches the RecordThread*/
     void startRecording() override;
 
+    /** Called by RecordThread after opening files */
+    void notifyRecordThreadFilesOpened();
+
     /* Called at end of recording; stops the RecordThread*/
     void stopRecording() override;
 

Source/Processors/RecordNode/RecordThread.cpp

@@ -114,6 +114,9 @@ void RecordThread::run()
 
     m_engine->openFiles (m_rootFolder, m_experimentNumber, m_recordingNumber);
 
+    if (recordNode != nullptr)
+        recordNode->notifyRecordThreadFilesOpened();
+
     //2-Wait until the first block has arrived, so we can align the timestamps
     bool isWaiting = false;
     while (! m_receivedFirstBlock && ! threadShouldExit())