Fix control reaches end of non-void function warning

Author: medengineer

Source/CoreServices.cpp

@@ -268,6 +268,7 @@ namespace CoreServices
 				if (node->getNodeId() == nodeId)
 					return node->getEngineId();
 			}
+			return String("NO_MATCHING_NODE_FOUND");
 		}
 
 		void setRecordEngine(String id, int nodeId, bool applyToAll)

Source/Processors/GenericProcessor/GenericProcessor.cpp

@@ -1923,6 +1923,8 @@ Plugin::Processor::Type GenericProcessor::typeFromString(String typeName)
         return Plugin::Processor::SINK;
     else if (typeName.equalsIgnoreCase("Utility"))
         return Plugin::Processor::UTILITY;
+    else
+        return Plugin::Processor::INVALID;
 }
 
 int GenericProcessor::getNumInputs() const  

Source/Processors/MessageCenter/MessageCenter.cpp

@@ -104,6 +104,8 @@ DataStream* MessageCenter::getMessageStream()
 {
     if (dataStreams.size() > 0)
         return dataStreams[0];
+
+    return nullptr;
 }
 
 void MessageCenter::setParameter(int parameterIndex, float newValue)

Source/Processors/SourceNode/SourceNode.cpp

@@ -150,8 +150,7 @@ float SourceNode::getSampleRate(int streamId) const
             if (stream->getStreamId() == streamId)
                 return stream->getSampleRate();
     }
-    else
-        return 44100.0;
+    return 44100.0;
 }
 
 

Source/UI/ControlPanel.cpp

@@ -1188,6 +1188,7 @@ String ControlPanel::getRecordingDirectoryPrependText()
             return field->value;
         }
     }
+    return "";
 }
 
 void ControlPanel::setRecordingDirectoryPrependText(String text)
@@ -1230,6 +1231,7 @@ String ControlPanel::getRecordingDirectoryAppendText()
             return field->value;
         }
     }
+    return "";
 }
 
 void ControlPanel::setRecordingDirectoryAppendText(String text)
@@ -1272,6 +1274,7 @@ String ControlPanel::getRecordingDirectoryBaseText()
             return field->value;
         }
     }
+    return "";
 }
 
 void ControlPanel::setRecordingDirectoryBaseText(String text)

Source/UI/FilenameConfigWindow.cpp

@@ -217,14 +217,7 @@ String FilenameFieldComponent::getNextValue(bool usePlaceholderText)
             }
         }
     }
-    else {
-        
-        //std::cout << "New directory NOT needed." << std::endl;
-        //std::cout << "Returning: " << value << std::endl;
-
-        return value;
-    }
-
+    return value;
 
 }