Add new processing options

Author: mohorev

.github/workflows/test.yml

@@ -24,6 +24,10 @@ jobs:
         run: |
           composer install --no-progress
 
+      - name: Run PHPStan
+        run: |
+          make phpstan
+
       - name: Run tests
         run: |
           make test

Makefile

@@ -1,5 +1,5 @@
 phpstan:
-	vendor/bin/phpstan analyse --level max src tests
+	vendor/bin/phpstan analyse -c phpstan.neon
 
 test: phpstan
 	vendor/bin/phpunit --verbose

composer.json

@@ -9,7 +9,7 @@
     },
     "require-dev": {
         "phpunit/phpunit": "^8.5.8|^9.3.3",
-        "phpstan/phpstan": "^0.12"
+        "phpstan/phpstan": "^2.1"
     },
     "autoload": {
         "psr-4": {

phpstan.neon

@@ -0,0 +1,7 @@
+parameters:
+    ignoreErrors:
+        - '#no value type specified in iterable type array#'
+    level: 9
+    paths:
+        - src
+        - tests

src/Options/AbstractOption.php

@@ -44,7 +44,7 @@ abstract public function data(): array;
      */
     public function value(): string
     {
-        $data = $this->data();
+        $data = array_map('strval', $this->data());
 
         array_unshift($data, $this->name());
 

src/Options/AutoRotate.php

@@ -6,12 +6,9 @@
 
 final class AutoRotate extends AbstractOption
 {
-    private bool $rotate;
-
-    public function __construct(bool $rotate = true)
-    {
-        $this->rotate = $rotate;
-    }
+    public function __construct(
+        private bool $rotate = true,
+    ) {}
 
     /**
      * @inheritDoc

src/Options/Blur.php

@@ -8,15 +8,13 @@
 
 final class Blur extends AbstractOption
 {
-    private float $sigma;
-
-    public function __construct(float $sigma)
+    public function __construct(
+        private float $sigma,
+    )
     {
         if ($sigma < 0) {
             throw new InvalidArgumentException(sprintf('Invalid blur: %s', $sigma));
         }
-
-        $this->sigma = $sigma;
     }
 
     /**

src/Options/CacheBuster.php

@@ -8,15 +8,12 @@
 
 final class CacheBuster extends AbstractOption
 {
-    private string $value;
-
-    public function __construct(string $value)
-    {
+    public function __construct(
+        private string $value,
+    ) {
         if (empty($value)) {
             throw new InvalidArgumentException('Cache buster cannot be empty');
         }
-
-        $this->value = $value;
     }
 
     /**

src/Options/Crop.php

@@ -8,7 +8,7 @@ final class Crop extends AbstractOption
 {
     private Width $width;
     private Height $height;
-    private ?Gravity $gravity = null;
+    private ?Gravity $gravity;
 
     public function __construct(int $width, int $height, Gravity|string|null $gravity = null)
     {

src/Options/Dpr.php

@@ -8,15 +8,12 @@
 
 final class Dpr extends AbstractOption
 {
-    private int $dpr;
-
-    public function __construct(int $dpr)
-    {
+    public function __construct(
+        private int $dpr,
+    ) {
         if ($dpr <= 0) {
             throw new InvalidArgumentException(sprintf('Invalid dpr: %s', $dpr));
         }
-
-        $this->dpr = $dpr;
     }
 
     /**