quic: truncate CONNECTION_CLOSE frame reason field

Author: efekrskl

src/quic/data.cc

@@ -7,9 +7,11 @@
 #include <openssl/ssl.h>
 #include <string_bytes.h>
 #include <v8.h>
+#include <algorithm>
 #include "bindingdata.h"
 #include "data.h"
 #include "defs.h"
+#include "simdutf.h"
 #include "util.h"
 
 namespace node {
@@ -218,6 +220,9 @@ void Store::MemoryInfo(MemoryTracker* tracker) const {
 // ============================================================================
 
 namespace {
+
+constexpr size_t kMaxConnectionCloseReasonLength = 256;
+
 constexpr std::string_view TypeName(QuicError::Type type) {
   switch (type) {
     case QuicError::Type::APPLICATION:
@@ -332,6 +337,18 @@ QuicError::operator const ngtcp2_ccerr*() const {
   return ptr_;
 }
 
+ngtcp2_ccerr QuicError::ToNgtcp2ConnectionCloseError() const {
+  ngtcp2_ccerr error = *ptr_;
+  error.reason = reason_c_str();
+
+  const size_t reasonlen =
+      std::min(reason_.size(), kMaxConnectionCloseReasonLength);
+
+  error.reasonlen = simdutf::trim_partial_utf8(reason_.data(), reasonlen);
+
+  return error;
+}
+
 std::string QuicError::reason_for_liberr(int liberr) {
   return ngtcp2_strerror(liberr);
 }

src/quic/data.h

@@ -260,6 +260,8 @@ class QuicError final : public MemoryRetainer {
   operator const ngtcp2_ccerr&() const;
   operator const ngtcp2_ccerr*() const;
 
+  ngtcp2_ccerr ToNgtcp2ConnectionCloseError() const;
+
   // Crypto errors are a subset of transport errors. The error code includes
   // the TLS alert code embedded within it.
   bool is_crypto_error() const;

src/quic/packet.cc

@@ -110,8 +110,9 @@ Packet::Ptr Packet::CreateConnectionClosePacket(
   if (!packet) return packet;
   ngtcp2_vec vec = *packet;
 
+  ngtcp2_ccerr wire_error = error.ToNgtcp2ConnectionCloseError();
   ssize_t nwrite = ngtcp2_conn_write_connection_close(
-      conn, nullptr, nullptr, vec.base, vec.len, error, uv_hrtime());
+      conn, nullptr, nullptr, vec.base, vec.len, &wire_error, uv_hrtime());
   if (nwrite < 0) return Ptr();
   packet->Truncate(static_cast<size_t>(nwrite));
   return packet;

src/quic/session.cc

@@ -3680,13 +3680,9 @@ void Session::SendConnectionClose() {
 
   ngtcp2_vec vec = *packet;
   Path path(impl_->local_address_, impl_->remote_address_);
-  ssize_t nwrite = ngtcp2_conn_write_connection_close(*this,
-                                                      &path,
-                                                      nullptr,
-                                                      vec.base,
-                                                      vec.len,
-                                                      impl_->last_error_,
-                                                      uv_hrtime());
+  ngtcp2_ccerr wire_error = impl_->last_error_.ToNgtcp2ConnectionCloseError();
+  ssize_t nwrite = ngtcp2_conn_write_connection_close(
+      *this, &path, nullptr, vec.base, vec.len, &wire_error, uv_hrtime());
 
   if (nwrite < 0) [[unlikely]] {
     return ErrorAndSilentClose();