fs: trace the mkstemp functions

fs.mkstemp(), fs.mkstempSync() and fsPromises.mkstemp() landed after
this branch, so the coverage test failed on them. Add the fs.mkstemp
channel with the same context as fs.mkdtemp.

Assisted-by: claude:fable-5.1
Signed-off-by: Tim Fish <tim@timfish.uk>

Author: timfish

doc/api/diagnostics_channel.md

@@ -1699,6 +1699,7 @@ of its forms: `stat` means `fs.stat()`, `fs.statSync()`, and
 | `fs.lutimes`    | `lutimes`                                                        | `path`, `atime`, `mtime` |
 | `fs.mkdir`      | `mkdir`                                                          | `path`                   |
 | `fs.mkdtemp`    | `mkdtemp`, `mkdtempDisposable`                                   | `prefix`                 |
+| `fs.mkstemp`    | `mkstemp`                                                        | `prefix`                 |
 | `fs.open`       | `open`                                                           | `path`                   |
 | `fs.openAsBlob` | `openAsBlob`                                                     | `path`                   |
 | `fs.opendir`    | `opendir`                                                        | `path`                   |

lib/fs.js

@@ -155,6 +155,7 @@ const {
   fsLutimes,
   fsMkdir,
   fsMkdtemp,
+  fsMkstemp,
   fsOpen,
   fsOpenAsBlob,
   fsRead,
@@ -4168,6 +4169,10 @@ function mkdtempDisposableSync(prefix, options) {
  * @returns {void}
  */
 function mkstemp(prefix, options, callback) {
+  if (this !== kTraced && fsMkstemp.hasSubscribers) {
+    const context = { api: 'callback', args: ArrayPrototypeSlice(arguments), prefix };
+    return traceCallback(fsMkstemp, context, mkstemp, arguments);
+  }
   callback = makeCallback(typeof options === 'function' ? options : callback);
 
   options = getOptions(options);
@@ -4195,6 +4200,10 @@ function mkstemp(prefix, options, callback) {
  * @returns {{ path: string | Buffer, fd: number }}
  */
 function mkstempSync(prefix, options) {
+  if (this !== kTraced && fsMkstemp.hasSubscribers) {
+    const context = { api: 'sync', args: ArrayPrototypeSlice(arguments), prefix };
+    return traceSync(fsMkstemp, context, mkstempSync, arguments);
+  }
   options = getOptions(options);
   if (BufferIsBuffer(prefix)) {
     options = { ...options, encoding: 'buffer' };

lib/internal/fs/promises.js

@@ -111,6 +111,7 @@ const {
   fsLutimes,
   fsMkdir,
   fsMkdtemp,
+  fsMkstemp,
   fsOpen,
   fsOpendir,
   fsRead,
@@ -2342,6 +2343,10 @@ async function mkdtemp(prefix, options) {
 }
 
 async function mkstemp(prefix, options) {
+  if (this !== kTraced && fsMkstemp.hasSubscribers) {
+    const context = { api: 'promise', args: ArrayPrototypeSlice(arguments), prefix };
+    return await tracePromise(fsMkstemp, context, mkstemp, arguments);
+  }
   options = getOptions(options);
   if (BufferIsBuffer(prefix)) {
     options = { ...options, encoding: 'buffer' };

lib/internal/fs/utils.js

@@ -1260,6 +1260,7 @@ const fsLstat = tracingChannel('fs.lstat');
 const fsLutimes = tracingChannel('fs.lutimes');
 const fsMkdir = tracingChannel('fs.mkdir');
 const fsMkdtemp = tracingChannel('fs.mkdtemp');
+const fsMkstemp = tracingChannel('fs.mkstemp');
 const fsOpen = tracingChannel('fs.open');
 const fsOpenAsBlob = tracingChannel('fs.openAsBlob');
 const fsOpendir = tracingChannel('fs.opendir');
@@ -1307,6 +1308,7 @@ module.exports = {
   fsLutimes,
   fsMkdir,
   fsMkdtemp,
+  fsMkstemp,
   fsOpen,
   fsOpenAsBlob,
   fsOpendir,

test/parallel/test-diagnostics-channel-fs-coverage.js

@@ -92,6 +92,7 @@ const syncOps = [
   ['mkdtempSync', 'mkdtemp', () => fs.mkdtempSync(fresh('tmp'))],
   ['mkdtempDisposableSync', 'mkdtemp',
    () => fs.mkdtempDisposableSync(fresh('tmp')).remove()],
+  ['mkstempSync', 'mkstemp', () => fs.closeSync(fs.mkstempSync(fresh('tmp')).fd)],
   ['openAsBlobSync', 'openAsBlob', () => fs.openAsBlobSync(file)],
   ['openSync', 'open', () => fs.closeSync(fs.openSync(file))],
   ['opendirSync', 'opendir', () => fs.opendirSync(newDir()).closeSync()],
@@ -141,6 +142,10 @@ const callbackOps = [
   ['lutimes', 'lutimes', (cb) => fs.lutimes(newLink(), now, now, cb)],
   ['mkdir', 'mkdir', (cb) => fs.mkdir(fresh('mkdir'), cb)],
   ['mkdtemp', 'mkdtemp', (cb) => fs.mkdtemp(fresh('tmp'), cb)],
+  ['mkstemp', 'mkstemp', (cb) => fs.mkstemp(fresh('tmp'), (err, file) => {
+    if (file !== undefined) fs.closeSync(file.fd);
+    cb(err);
+  })],
   ['open', 'open', (cb) => fs.open(file, (err, fd) => {
     if (fd !== undefined) fs.closeSync(fd);
     cb(err);
@@ -188,6 +193,7 @@ const promiseOps = [
   ['mkdtemp', 'mkdtemp', () => fsp.mkdtemp(fresh('tmp'))],
   ['mkdtempDisposable', 'mkdtemp',
    async () => (await fsp.mkdtempDisposable(fresh('tmp'))).remove()],
+  ['mkstemp', 'mkstemp', async () => (await fsp.mkstemp(fresh('tmp'))).handle.close()],
   ['open', 'open', async () => (await fsp.open(file)).close()],
   ['opendir', 'opendir', async () => (await fsp.opendir(newDir())).close()],
   ['openAsBlob', 'openAsBlob', () => fs.openAsBlob(file)],