fixup! build: add --shared-abseil configure flag

Author: aduh95

configure.py

@@ -286,117 +286,23 @@
     action='store_true',
     dest='shared_abseil',
     default=None,
-    help='link to a shared googletest DLL instead of static linking')
+    help='link to a shared Abseil DLL instead of static linking')
 
 shared_optgroup.add_argument('--shared-abseil-includes',
     action='store',
     dest='shared_abseil_includes',
-    help='directory containing googletest header files')
+    help='directory containing Abseil header files')
 
 shared_optgroup.add_argument('--shared-abseil-libname',
     action='store',
     dest='shared_abseil_libname',
-    default=','.join([
-      'absl_base',
-      'absl_borrowed_fixup_buffer',
-      'absl_city',
-      'absl_civil_time',
-      'absl_cord_internal',
-      'absl_cord',
-      'absl_cordz_functions',
-      'absl_cordz_handle',
-      'absl_cordz_info',
-      'absl_cordz_sample_token',
-      'absl_crc_cord_state',
-      'absl_crc_cpu_detect',
-      'absl_crc_internal',
-      'absl_crc32c',
-      'absl_debugging_internal',
-      'absl_decode_rust_punycode',
-      'absl_demangle_internal',
-      'absl_demangle_rust',
-      'absl_die_if_null',
-      'absl_examine_stack',
-      'absl_exponential_biased',
-      'absl_failure_signal_handler',
-      'absl_flags_commandlineflag_internal',
-      'absl_flags_commandlineflag',
-      'absl_flags_config',
-      'absl_flags_internal',
-      'absl_flags_marshalling',
-      'absl_flags_parse',
-      'absl_flags_private_handle_accessor',
-      'absl_flags_program_name',
-      'absl_flags_reflection',
-      'absl_flags_usage_internal',
-      'absl_flags_usage',
-      'absl_generic_printer_internal',
-      'absl_graphcycles_internal',
-      'absl_hash',
-      'absl_hashtable_profiler',
-      'absl_hashtablez_sampler',
-      'absl_int128',
-      'absl_kernel_timeout_internal',
-      'absl_leak_check',
-      'absl_log_entry',
-      'absl_log_flags',
-      'absl_log_globals',
-      'absl_log_initialize',
-      'absl_log_internal_check_op',
-      'absl_log_internal_conditions',
-      'absl_log_internal_fnmatch',
-      'absl_log_internal_format',
-      'absl_log_internal_globals',
-      'absl_log_internal_log_sink_set',
-      'absl_log_internal_message',
-      'absl_log_internal_nullguard',
-      'absl_log_internal_proto',
-      'absl_log_internal_structured_proto',
-      'absl_log_severity',
-      'absl_log_sink',
-      'absl_malloc_internal',
-      'absl_periodic_sampler',
-      'absl_poison',
-      'absl_profile_builder',
-      'absl_random_distributions',
-      'absl_random_internal_distribution_test_util',
-      'absl_random_internal_entropy_pool',
-      'absl_random_internal_platform',
-      'absl_random_internal_randen_hwaes_impl',
-      'absl_random_internal_randen_hwaes',
-      'absl_random_internal_randen_slow',
-      'absl_random_internal_randen',
-      'absl_random_internal_seed_material',
-      'absl_random_seed_gen_exception',
-      'absl_random_seed_sequences',
-      'absl_raw_hash_set',
-      'absl_raw_logging_internal',
-      'absl_scoped_mock_log',
-      'absl_scoped_set_env',
-      'absl_spinlock_wait',
-      'absl_stacktrace',
-      'absl_status_matchers',
-      'absl_status',
-      'absl_statusor',
-      'absl_str_format_internal',
-      'absl_strerror',
-      'absl_strings_internal',
-      'absl_strings',
-      'absl_symbolize',
-      'absl_synchronization',
-      'absl_throw_delegate',
-      'absl_time_zone',
-      'absl_time',
-      'absl_tracing_internal',
-      'absl_utf8_for_code_point',
-      'absl_vlog_config_internal',
-    ]),
+    default=None,
     help='alternative lib name to link to [default: %(default)s]')
 
 shared_optgroup.add_argument('--shared-abseil-libpath',
     action='store',
     dest='shared_abseil_libpath',
-    help='a directory to search for the shared googletest DLL')
+    help='a directory to search for the shared Abseil DLL')
 
 shared_optgroup.add_argument('--shared-gtest',
     action='store_true',
@@ -2937,214 +2843,63 @@ def make_bin_override():
   'absl_algorithm_container',
   'absl_algorithm',
   'absl_any_invocable',
-  'absl_any',
-  'absl_atomic_hook',
-  'absl_bad_any_cast',
-  'absl_bad_optional_access',
-  'absl_bad_variant_access',
-  'absl_base_internal',
   'absl_base',
   'absl_bind_front',
   'absl_bits',
-  'absl_borrowed_fixup_buffer',
-  'absl_bounded_utf8_length_sequence',
   'absl_btree',
   'absl_charset',
-  'absl_check',
-  'absl_chunked_queue',
-  'absl_city',
-  'absl_civil_time',
-  'absl_cleanup_internal',
   'absl_cleanup',
-  'absl_common_policy_traits',
-  'absl_compare',
-  'absl_compressed_tuple',
   'absl_config',
-  'absl_constexpr_testing_internal',
-  'absl_container_common',
-  'absl_container_memory',
-  'absl_cord_internal',
-  'absl_cord_test_helpers',
   'absl_cord',
-  'absl_cordz_functions',
-  'absl_cordz_handle',
-  'absl_cordz_info',
-  'absl_cordz_sample_token',
-  'absl_cordz_statistics',
-  'absl_cordz_update_scope',
-  'absl_cordz_update_tracker',
   'absl_core_headers',
-  'absl_crc_cord_state',
-  'absl_crc_cpu_detect',
-  'absl_crc_internal',
-  'absl_crc32c',
-  'absl_debugging_internal',
-  'absl_debugging',
-  'absl_decode_rust_punycode',
-  'absl_demangle_internal',
-  'absl_demangle_rust',
   'absl_die_if_null',
   'absl_dynamic_annotations',
-  'absl_endian',
-  'absl_errno_saver',
-  'absl_examine_stack',
-  'absl_exponential_biased',
   'absl_failure_signal_handler',
   'absl_fast_type_id',
   'absl_fixed_array',
-  'absl_flags_commandlineflag_internal',
-  'absl_flags_commandlineflag',
-  'absl_flags_config',
-  'absl_flags_internal',
-  'absl_flags_marshalling',
-  'absl_flags_parse',
-  'absl_flags_path_util',
-  'absl_flags_private_handle_accessor',
-  'absl_flags_program_name',
-  'absl_flags_reflection',
-  'absl_flags_usage_internal',
-  'absl_flags_usage',
-  'absl_flags',
   'absl_flat_hash_map',
   'absl_flat_hash_set',
   'absl_function_ref',
-  'absl_generic_printer_internal',
-  'absl_graphcycles_internal',
   'absl_has_ostream_operator',
   'absl_hash_container_defaults',
-  'absl_hash_function_defaults',
-  'absl_hash_policy_traits',
-  'absl_hash_testing',
   'absl_hash',
-  'absl_hashtable_control_bytes',
-  'absl_hashtable_debug_hooks',
-  'absl_hashtable_debug',
-  'absl_hashtable_profiler',
-  'absl_hashtablez_sampler',
-  'absl_heterogeneous_lookup_testing',
-  'absl_inlined_vector_internal',
   'absl_inlined_vector',
   'absl_int128',
-  'absl_iterator_traits_internal',
-  'absl_iterator_traits_test_helper_internal',
-  'absl_kernel_timeout_internal',
   'absl_layout',
   'absl_leak_check',
   'absl_linked_hash_map',
   'absl_linked_hash_set',
   'absl_log_entry',
-  'absl_log_flags',
   'absl_log_globals',
   'absl_log_initialize',
-  'absl_log_internal_append_truncated',
-  'absl_log_internal_check_impl',
-  'absl_log_internal_check_op',
-  'absl_log_internal_conditions',
-  'absl_log_internal_config',
-  'absl_log_internal_container',
-  'absl_log_internal_flags',
-  'absl_log_internal_fnmatch',
-  'absl_log_internal_format',
-  'absl_log_internal_globals',
-  'absl_log_internal_log_impl',
-  'absl_log_internal_log_sink_set',
-  'absl_log_internal_message',
-  'absl_log_internal_nullguard',
-  'absl_log_internal_nullstream',
-  'absl_log_internal_proto',
-  'absl_log_internal_strip',
-  'absl_log_internal_structured_proto',
-  'absl_log_internal_structured',
-  'absl_log_internal_voidify',
   'absl_log_severity',
   'absl_log_sink_registry',
   'absl_log_sink',
-  'absl_log_streamer',
-  'absl_log_structured',
-  'absl_log',
-  'absl_malloc_internal',
   'absl_memory',
-  'absl_meta',
   'absl_no_destructor',
   'absl_node_hash_map',
   'absl_node_hash_set',
-  'absl_node_slot_policy',
-  'absl_non_temporal_arm_intrinsics',
-  'absl_non_temporal_memcpy',
-  'absl_nullability_traits_internal',
   'absl_nullability',
-  'absl_numeric_representation'
-  'absl_numeric'
   'absl_optional',
   'absl_overload',
-  'absl_periodic_sampler',
-  'absl_poison',
   'absl_prefetch',
-  'absl_pretty_function',
-  'absl_profile_builder',
   'absl_random_bit_gen_ref',
   'absl_random_distributions',
-  'absl_random_internal_distribution_caller',
-  'absl_random_internal_distribution_test_util',
-  'absl_random_internal_entropy_pool',
-  'absl_random_internal_fast_uniform_bits',
-  'absl_random_internal_fastmath',
-  'absl_random_internal_generate_real',
-  'absl_random_internal_iostream_state_saver',
-  'absl_random_internal_mock_helpers',
-  'absl_random_internal_nonsecure_base',
-  'absl_random_internal_pcg_engine',
-  'absl_random_internal_platform',
-  'absl_random_internal_randen_engine',
-  'absl_random_internal_randen_hwaes_impl',
-  'absl_random_internal_randen_hwaes',
-  'absl_random_internal_randen_slow',
-  'absl_random_internal_randen',
-  'absl_random_internal_salted_seed_seq',
-  'absl_random_internal_seed_material',
-  'absl_random_internal_traits',
-  'absl_random_internal_uniform_helper',
-  'absl_random_internal_wide_multiply',
-  'absl_random_mocking_bit_gen',
   'absl_random_random',
-  'absl_random_seed_gen_exception',
-  'absl_random_seed_sequences',
-  'absl_raw_hash_map',
-  'absl_raw_hash_set_resize_impl',
-  'absl_raw_hash_set',
   'absl_raw_logging_internal',
-  'absl_requires_internal',
-  'absl_sample_recorder',
-  'absl_scoped_mock_log',
-  'absl_scoped_set_env',
   'absl_span',
-  'absl_spinlock_wait',
-  'absl_spy_hash_state',
   'absl_stacktrace',
-  'absl_status_matchers',
   'absl_status',
   'absl_statusor',
-  'absl_str_format_internal',
   'absl_str_format',
-  'absl_strerror',
   'absl_string_view',
-  'absl_strings_append_and_overwrite',
-  'absl_strings_internal',
-  'absl_strings_resize_and_overwrite',
   'absl_strings',
   'absl_symbolize',
   'absl_synchronization',
-  'absl_throw_delegate',
-  'absl_time_zone',
   'absl_time',
-  'absl_tracing_internal',
   'absl_type_traits',
-  'absl_utf8_for_code_point',
   'absl_utility',
   'absl_variant',
-  'absl_vlog_config_internal',
-  'absl_vlog_is_on',
-  'absl_weakly_mixed_integer',
 ])
 configure_library('ada', output)
 configure_library('simdjson', output)

tools/v8_gypfiles/v8.gyp

@@ -526,7 +526,7 @@
             'v8_libplatform',
           ]
         }],
-        ['want_separate_host_toolset and node_shared_abseil=="false"', {
+        ['node_shared_abseil=="false"', {
           'dependencies': ['abseil.gyp:abseil'],
         }],
         ['OS=="win" and clang==1', {