Skip to content

Commit 3a34dd8

Browse files
committed
build: derive V8_LOGGING_LEVEL from dcheck_always_on
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
1 parent 5c447f6 commit 3a34dd8

1 file changed

Lines changed: 13 additions & 1 deletion

File tree

tools/v8_gypfiles/features.gypi

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -461,9 +461,21 @@
461461
'defines': ['V8_ENABLE_SEEDED_ARRAY_INDEX_HASH',],
462462
}],
463463
['dcheck_always_on!=0', {
464-
'defines': ['DEBUG',],
464+
'defines': [
465+
'DEBUG',
466+
'V8_LOGGING_LEVEL=2', # Print file, line, message on fatal checks
467+
],
465468
}, {
466469
'defines': ['NDEBUG',],
470+
'configurations': {
471+
'Debug': {
472+
'defines': ['V8_LOGGING_LEVEL=2',],
473+
},
474+
'Release': {
475+
# Only log message (without file or line) on fatal checks
476+
'defines': ['V8_LOGGING_LEVEL=1',],
477+
},
478+
},
467479
}],
468480
['v8_enable_verify_csa==1', {
469481
'defines': ['ENABLE_VERIFY_CSA',],

0 commit comments

Comments
 (0)