Skip to content

Commit 01ce2c5

Browse files
committed
doc: change line threshold and reword subsystem test in large PR policy
Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk>
1 parent c4336d9 commit 01ce2c5

1 file changed

Lines changed: 7 additions & 6 deletions

File tree

doc/contributing/large-pull-requests.md

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,16 +26,17 @@ requests in the Node.js project.
2626

2727
## What qualifies as a large pull request
2828

29-
A pull request is considered large when it exceeds **5000 lines** of net
30-
change (lines added minus lines deleted). This threshold applies across all
29+
A pull request is considered large when it exceeds **5000 lines added** and/or
30+
**5000 lines deleted**, as reported by Git. This threshold applies across all
3131
files in the pull request, including changes in `deps/`, `test/`, `doc/`,
3232
`lib/`, `src/`, and `tools/`.
3333

34-
Any pull request that adds a new subsystem, e.g. `node:foo` or `node:foo/bar`,
35-
is automatically considered a large pull request and subject to the same rules.
34+
Changes in `deps/` are deliberately included in this count. Dependency changes
35+
are sensitive because they often receive less scrutiny than first-party code.
3636

37-
Changes in `deps/` are included in this count. Dependency changes are
38-
sensitive because they often receive less scrutiny than first-party code.
37+
Additionally, any pull request that adds a new module to the public API (e.g.
38+
`node:foo` or `node:foo/bar`) is automatically considered a large pull request,
39+
irrespective of its size.
3940

4041
The following categories of pull requests are **excluded** from this policy,
4142
even if they exceed the line threshold:

0 commit comments

Comments
 (0)