From 5d9f06ebcbebc5b8b6fd77721b600a79aa8cfb07 Mon Sep 17 00:00:00 2001 From: Filip Skokan Date: Wed, 14 Oct 2026 12:25:26 +0200 Subject: [PATCH] jenkins: skip SmartOS for pull request tests Keep SmartOS in daily and release runs by limiting the exclusion to GIT_REMOTE_REF pull refs and test builds. Refs: https://github.com/nodejs/build/issues/4457 Assisted-by: Codex Signed-off-by: Filip Skokan --- jenkins/scripts/VersionSelectorScript.groovy | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/jenkins/scripts/VersionSelectorScript.groovy b/jenkins/scripts/VersionSelectorScript.groovy index 42028e742..f27200d04 100644 --- a/jenkins/scripts/VersionSelectorScript.groovy +++ b/jenkins/scripts/VersionSelectorScript.groovy @@ -11,6 +11,10 @@ def noVer = { nodeVersion -> false } def releaseType = { buildType -> buildType == 'release' } def testType = { buildType -> buildType == 'test' } def anyType = { buildType -> true } +// node-test-pull-request passes the pull ref down to every sub-job; daily +// and release jobs pass a branch ref +def isPullRequest = new String(parameters['GIT_REMOTE_REF'] ?: '') ==~ /refs\/pull\/.+/ +def prTestType = { buildType -> buildType == 'test' && isPullRequest } def buildExclusions = [ // Given a machine label, build type (release or !release) and a Node.js @@ -54,6 +58,9 @@ def buildExclusions = [ [ /^aix72-power9/, releaseType, lt(26) ], // Build releases on Power 9 for >=26 // SmartOS ----------------------------------------------- + // Not run for pull requests, node-daily-* still covers them + // https://github.com/nodejs/build/issues/4457 + [ /^smartos/, prTestType, allVer ], [ /^smartos22/, anyType, gte(26) ], // Shared libs docker containers -------------------------