Skip to content

Commit 7036353

Browse files
committed
Dont't show favicons.
Fixes #92.
1 parent d46253a commit 7036353

3 files changed

Lines changed: 9 additions & 35 deletions

File tree

popup-app/components/IdpSelect.css

Lines changed: 5 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -6,18 +6,17 @@
66

77
.idp {
88
flex: 1 100%;
9+
910
margin: .5em;
11+
padding: .75em .5em;
1012

1113
border: none;
12-
border-radius: 2px;
13-
padding: .5em;
14+
border-radius: 10px;
1415
background-color: rgb(61, 109, 211);
1516
color: #fff;
17+
transition: background-color 0.4s;
1618

17-
display: flex;
18-
justify-content: space-between;
19-
align-items: center;
20-
transition: background-color 0.4s, box-shadow 0.4s;
19+
cursor: pointer;
2120
}
2221

2322
.idp:hover,
@@ -26,18 +25,6 @@
2625
box-shadow: 1px 1px rgb(46, 80, 151);
2726
}
2827

29-
.idp:active {
30-
cursor: pointer;
31-
box-shadow: inset 1px 1px rgb(46, 80, 152);
32-
}
33-
34-
.idp .icon {
35-
display: flex;
36-
height: 42px;
37-
border-radius: 2px;
38-
margin-left: .5em;
39-
}
40-
4128
.custom-idp {
4229
display: flex;
4330
flex-wrap: nowrap;

popup-app/components/IdpSelect.js

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -121,14 +121,7 @@ class IdpSelect extends React.Component {
121121

122122
const Idp = ({ idp, handleSelectIdp }) => (
123123
<button className="idp" onClick={handleSelectIdp}>
124-
<span class="label">Log in with {idp.displayName}</span>
125-
{idp.iconUrl ? (
126-
<img className="icon" src={idp.iconUrl} alt="" />
127-
) : (
128-
<svg className="icon" width="32" viewBox="0 0 100 20" alt="">
129-
<path d="M41.2,50c0-4.9,4-8.8,8.8-8.8s8.8,4,8.8,8.8c0,4.9-4,8.8-8.8,8.8S41.2,54.9,41.2,50z M80.3,41.2c-4.9,0-8.8,4-8.8,8.8 c0,4.9,4,8.8,8.8,8.8s8.8-4,8.8-8.8C89.2,45.1,85.2,41.2,80.3,41.2z M19.7,41.2c-4.9,0-8.8,4-8.8,8.8c0,4.9,4,8.8,8.8,8.8 s8.8-4,8.8-8.8C28.5,45.1,24.5,41.2,19.7,41.2z" />
130-
</svg>
131-
)}
124+
{idp.displayName}
132125
</button>
133126
)
134127

popup-app/index.js

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,11 @@ import './index.css'
1414
const defaultIdps = [
1515
{
1616
displayName: 'Solid Community',
17-
url: 'https://solid.community/',
18-
iconUrl: 'https://solidtest.space/favicon.ico'
17+
url: 'https://solid.community/'
1918
},
2019
{
2120
displayName: 'Solid Test Space',
22-
url: 'https://solidtest.space/',
23-
iconUrl: 'https://solidtest.space/favicon.ico'
21+
url: 'https://solidtest.space/'
2422
}
2523
]
2624

@@ -43,11 +41,7 @@ findAppOrigin()
4341
} else {
4442
const idps = [...defaultIdps]
4543
if (!idps.some(idp => idp.url === baseUrl)) {
46-
idps.unshift({
47-
displayName: host,
48-
url: baseUrl,
49-
iconUrl: baseUrl + 'favicon.ico'
50-
})
44+
idps.unshift({ displayName: host, url: baseUrl })
5145
}
5246
element = (
5347
<IdpSelect idps={idps} appOrigin={appOrigin} appName={appName} />

0 commit comments

Comments
 (0)