FIXUP

Author: fengmk2

.github/workflows/nodejs.yml

@@ -45,10 +45,39 @@ jobs:
         run: pnpm run build
 
   test:
-    name: Node.js
-    uses: node-modules/github-actions/.github/workflows/node-test.yml@master
-    with:
-      os: 'ubuntu-latest, macos-latest, windows-latest'
-      version: '16, 18, 20, 22, 24'
-    secrets:
-      CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
+    strategy:
+      fail-fast: false
+      matrix:
+        os: ['ubuntu-latest', 'macos-latest', 'windows-latest']
+        node: ['16', '18', '20', '22', '24']
+
+    name: Test (${{ matrix.os }}, ${{ matrix.node }})
+    runs-on: ${{ matrix.os }}
+
+    concurrency:
+      group: test-${{ github.workflow }}-#${{ github.event.pull_request.number || github.head_ref || github.ref }}-(${{ matrix.os }}, ${{ matrix.node }})
+      cancel-in-progress: true
+
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6
+
+      - name: Install pnpm
+        uses: pnpm/action-setup@41ff72655975bd51cab0327fa583b6e92b6d3061 # v4
+
+      - name: Set up Node.js
+        uses: actions/setup-node@395ad3262231945c25e8478fd5baf05154b1d79f # v6
+        with:
+          node-version: ${{ matrix.node }}
+          cache: 'pnpm'
+
+      - name: Install dependencies
+        run: pnpm install --frozen-lockfile
+
+      - name: Run tests
+        run: pnpm run ci
+
+      - name: Code Coverage
+        uses: codecov/codecov-action@5a1091511ad55cbe89839c7260b706298ca349f7 # v5
+        with:
+          use_oidc: true

src/formstream.d.ts

@@ -1,3 +1,7 @@
 declare module 'formstream' {
-  export default class FormStream {}
+  export default class FormStream {
+    headers(): Record<string, string>;
+    file(name: string, path: string): void;
+    field(name: string, value: string): void;
+  }
 }

test/HttpClient.test.ts

@@ -11,6 +11,7 @@ import { describe, it, beforeAll, afterAll } from 'vitest';
 import { HttpClient, RawResponseWithMeta, getGlobalDispatcher } from '../src/index.js';
 import { startServer } from './fixtures/server.js';
 import { nodeMajorVersion } from './utils.js';
+import { AddressInfo } from 'node:net';
 
 const pems = selfsigned.generate([], {
   keySize: nodeMajorVersion() >= 22 ? 2048 : 1024,
@@ -157,7 +158,7 @@ describe('HttpClient.test.ts', () => {
         },
       });
 
-      const url = `https://localhost:${server.address()!.port}`;
+      const url = `https://localhost:${(server.address() as AddressInfo).port}`;
       let response = await httpClient.request<string>(url, {
         dataType: 'text',
         headers: {
@@ -220,7 +221,7 @@ describe('HttpClient.test.ts', () => {
         },
       });
 
-      const url = `https://localhost:${server.address()!.port}`;
+      const url = `https://localhost:${(server.address() as AddressInfo).port}`;
       let response = await httpClient.request<string>(url, {
         dataType: 'text',
         headers: {
@@ -254,7 +255,7 @@ describe('HttpClient.test.ts', () => {
   });
 
   describe('clientOptions.lookup', () => {
-    it('should work with custom lookup on HTTP protol', async () => {
+    it('should work with custom lookup on HTTP protocol', async () => {
       let lookupCallCounter = 0;
       const httpclient = new HttpClient({
         // mock lookup delay
@@ -411,7 +412,7 @@ describe('HttpClient.test.ts', () => {
 
     it('should throw error when request address is ip v6', async () => {
       const httpclient = new HttpClient({
-        checkAddress(address, family) {
+        checkAddress(_address, family) {
           return family !== 6;
         },
       });

test/diagnostics_channel.test.ts

@@ -12,6 +12,7 @@ import type { RequestDiagnosticsMessage, ResponseDiagnosticsMessage } from '../s
 import symbols from '../src/symbols.js';
 import { startServer } from './fixtures/server.js';
 import { nodeMajorVersion } from './utils.js';
+import { AddressInfo } from 'node:net';
 
 describe('diagnostics_channel.test.ts', () => {
   let close: any;
@@ -217,7 +218,7 @@ describe('diagnostics_channel.test.ts', () => {
     });
 
     let traceId = `mock-traceid-${Date.now()}`;
-    _url = `https://localhost:${server.address().port}`;
+    _url = `https://localhost:${(server.address() as AddressInfo).port}`;
     let response = await httpClient.request(`${_url}?head=true`, {
       method: 'HEAD',
       opaque: {

test/fixtures/server.ts

@@ -21,13 +21,14 @@ export async function startServer(options?: {
   let server: Server;
   const requestHandler = async (req: IncomingMessage, res: ServerResponse) => {
     const startTime = Date.now();
-    req.socket[requestsPerSocket] = (req.socket[requestsPerSocket] || 0) + 1;
+    const socket = req.socket as any;
+    socket[requestsPerSocket] = (socket[requestsPerSocket] || 0) + 1;
     if (server.keepAliveTimeout) {
       res.setHeader('Keep-Alive', 'timeout=' + server.keepAliveTimeout / 1000);
     }
     const urlObject = new URL(req.url!, `http://${req.headers.host}`);
     const pathname = urlObject.pathname;
-    res.setHeader('x-requests-persocket', req.socket[requestsPerSocket]);
+    res.setHeader('x-requests-persocket', socket[requestsPerSocket]);
     res.setHeader('x-requests-socket-port', req.socket.remotePort!);
     res.setHeader('X-Foo', 'bar');
     res.setHeader('x-href', urlObject.href);
@@ -321,8 +322,8 @@ export async function startServer(options?: {
         url: req.url,
         href: urlObject.href,
         headers: req.headers,
-        files: {},
-        form: {},
+        files: {} as Record<string, any>,
+        form: {} as Record<string, any>,
       };
       bb.on('file', (name, file, info) => {
         const { filename, encoding, mimeType } = info;

test/fixtures/socket_server.ts

@@ -12,7 +12,7 @@ export async function startServer(): Promise<{
   const socketPath = `${socketPathPrefix}_${index++}`;
   const unixSocketServer = createServer();
 
-  unixSocketServer.on('request', (req, res) => {
+  unixSocketServer.on('request', (_req, res) => {
     res.setHeader('Content-Type', 'application/json');
     res.write(JSON.stringify({ a: 1 }));
     res.end();

test/mts/src/index.mts

@@ -1,3 +1,4 @@
+// @ts-expect-error ignore type error
 import { request, IncomingHttpHeaders } from 'urllib';
 const responseObj = await request('test');
 

test/options.stream.test.ts

@@ -89,7 +89,7 @@ describe('options.stream.test.ts', () => {
     const response = await urllib.request(`${_url}multipart`, {
       method: 'post',
       dataType: 'json',
-      stream: form,
+      stream: form as any,
       headers: form.headers(),
     });
     assert.equal(response.status, 200);

test/options.timeout.test.ts

@@ -8,6 +8,7 @@ import { describe, it, beforeAll, afterAll } from 'vitest';
 import urllib, { HttpClientRequestTimeoutError, HttpClient } from '../src/index.js';
 import { startServer } from './fixtures/server.js';
 import { nodeMajorVersion } from './utils.js';
+import { AddressInfo } from 'node:net';
 
 const pems = selfsigned.generate([], {
   keySize: nodeMajorVersion() >= 22 ? 2048 : 1024,
@@ -93,7 +94,7 @@ describe('options.timeout.test.ts', () => {
     server.listen(0);
     await once(server, 'listening');
 
-    const url = `https://localhost:${server.address()!.port}`;
+    const url = `https://localhost:${(server.address() as AddressInfo).port}`;
     await assert.rejects(
       async () => {
         await httpClient.request(url, {
@@ -171,7 +172,7 @@ describe('options.timeout.test.ts', () => {
         assert.equal(err.res!.status, -1);
         assert(err.headers);
         assert.equal(err.status, -1);
-        err.cause && assert.equal(err.cause.name, 'HeadersTimeoutError');
+        err.cause && assert.equal((err.cause as any).name, 'HeadersTimeoutError');
         return true;
       },
     );

test/urllib.options.rejectUnauthorized-false.test.ts

@@ -8,6 +8,7 @@ import { describe, it, beforeAll, afterAll } from 'vitest';
 import urllib, { HttpClient } from '../src/index.js';
 import { startServer } from './fixtures/server.js';
 import { nodeMajorVersion } from './utils.js';
+import { AddressInfo } from 'node:net';
 
 describe('urllib.options.rejectUnauthorized-false.test.ts', () => {
   let close: any;
@@ -60,7 +61,7 @@ describe('urllib.options.rejectUnauthorized-false.test.ts', () => {
       },
     });
 
-    const url = `https://localhost:${server.address()!.port}`;
+    const url = `https://localhost:${(server.address() as AddressInfo).port}`;
     const response1 = await httpClient.request(url, {});
     assert.equal(response1.status, 200);
     assert.equal(response1.data.toString(), 'hello h2!');