Skip to content

Commit 5dc9b1d

Browse files
Add warning for plaintext passwords, set default password mode to secure
Signed-off-by: Sebastian Sterk <sebastian@wiuwiu.de>
1 parent 66747db commit 5dc9b1d

2 files changed

Lines changed: 5 additions & 2 deletions

File tree

README.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ Add the following to your `config.php`:
195195
2 => 'dbuser',
196196
3 => 'dbuserpassword',
197197
4 => 'xmppdomain',
198-
5 => true,
198+
5 => true,
199199
),
200200
),
201201
),
@@ -207,6 +207,9 @@ Add the following to your `config.php`:
207207
4 - XMPP Domain
208208
5 - Hashed Passwords in Database (true) / Plaintext Passwords in Database (false)
209209

210+
**⚠⚠ Warning:** If you need to set *5 (Hashed Password in Database)* to false, your Prosody Instance is storing passwords in plaintext. This is insecure and not recommended. We highly recommend that you change your Prosody configuration to protect the passwords of your Prosody users. ⚠⚠
211+
212+
210213
Alternatives
211214
------------
212215
Other extensions allow connecting to external user databases directly via SQL, which may be faster:

lib/xmpp.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ class OC_User_XMPP extends \OCA\user_external\Base {
2222
private $xmppDomain;
2323
private $passwordHashed;
2424

25-
public function __construct($host, $xmppDb, $xmppDbUser, $xmppDbPassword, $xmppDomain, $passwordHashed) {
25+
public function __construct($host, $xmppDb, $xmppDbUser, $xmppDbPassword, $xmppDomain, $passwordHashed = true) {
2626
parent::__construct($host);
2727
$this->host = $host;
2828
$this->xmppDb = $xmppDb;

0 commit comments

Comments
 (0)