Merge pull request #1666 from nextcloud-libraries/fix/oc-m-time

fix(uploader): only set mtime if valid value is passed

Author: susnux

lib/uploader/uploader.ts

@@ -531,7 +531,7 @@ export class Uploader {
 								},
 								headers: {
 									...this._customHeaders,
-									'X-OC-Mtime': Math.floor(file.lastModified / 1000),
+									...this._mtimeHeader(file),
 									'OC-Total-Length': file.size,
 									'Content-Type': 'application/octet-stream',
 								},
@@ -579,7 +579,7 @@ export class Uploader {
 							url: `${tempUrl}/.file`,
 							headers: {
 								...this._customHeaders,
-								'X-OC-Mtime': Math.floor(file.lastModified / 1000),
+								...this._mtimeHeader(file),
 								'OC-Total-Length': file.size,
 								Destination: encodedDestinationFile,
 							},
@@ -633,7 +633,7 @@ export class Uploader {
 								},
 								headers: {
 									...this._customHeaders,
-									'X-OC-Mtime': Math.floor(file.lastModified / 1000),
+									...this._mtimeHeader(file),
 									'Content-Type': file.type,
 								},
 							},
@@ -685,4 +685,19 @@ export class Uploader {
 		return promise
 	}
 
+	/**
+	 * Create modification time headers if valid value is available.
+	 * It can be invalid on Android devices if SD cards with NTFS / FAT are used,
+	 * as those files might use the NT epoch for time so the value will be negative.
+	 *
+	 * @param file The file to upload
+	 */
+	private _mtimeHeader(file: File): { 'X-OC-Mtime'?: number } {
+		const mtime = Math.floor(file.lastModified / 1000)
+		if (mtime > 0) {
+			return { 'X-OC-Mtime': mtime }
+		}
+		return {}
+	}
+
 }