From 60dc772b88595cd0c632a922a392a33e0d33172c Mon Sep 17 00:00:00 2001 From: skjnldsv Date: Wed, 9 Sep 2026 18:00:18 +0200 Subject: [PATCH] fix(dialog): name the sharee "recipient" everywhere The dialog called the same thing people, participants and recipients. Settle on recipient, which the API and the code already use. The "Invited people" tab keeps its name for now: it labels a share type rather than the sharee, and renaming it is a design call. Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: skjnldsv --- lib/dialog/components/RecipientRow.spec.ts | 4 ++-- lib/dialog/components/RecipientRow.vue | 2 +- lib/dialog/components/SharePanel.vue | 12 ++++++------ tests/ct/RecipientRow.spec.ts | 2 +- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/lib/dialog/components/RecipientRow.spec.ts b/lib/dialog/components/RecipientRow.spec.ts index e5d501b..3e51c58 100644 --- a/lib/dialog/components/RecipientRow.spec.ts +++ b/lib/dialog/components/RecipientRow.spec.ts @@ -48,10 +48,10 @@ function mountRow(r: SharingRecipient = recipient()) { return { wrapper, share } } -/** Click the "Remove participant" action, found by its label. */ +/** Click the "Remove recipient" action, found by its label. */ async function clickRemove(wrapper: ReturnType['wrapper']) { const action = wrapper.findAllComponents({ name: 'NcActionButton' }) - .find((button) => button.text().includes('Remove participant')) + .find((button) => button.text().includes('Remove recipient')) expect(action, 'the remove action is rendered').toBeDefined() action!.vm.$emit('click') await nextTick() diff --git a/lib/dialog/components/RecipientRow.vue b/lib/dialog/components/RecipientRow.vue index f0cf7f2..7099b4d 100644 --- a/lib/dialog/components/RecipientRow.vue +++ b/lib/dialog/components/RecipientRow.vue @@ -40,7 +40,7 @@ - {{ t('Remove participant') }} + {{ t('Remove recipient') }} diff --git a/lib/dialog/components/SharePanel.vue b/lib/dialog/components/SharePanel.vue index f6c2e82..7fee63e 100644 --- a/lib/dialog/components/SharePanel.vue +++ b/lib/dialog/components/SharePanel.vue @@ -30,7 +30,7 @@ :modelValue="selectedRecipients" class="share-panel__recipient-search" :multiple="true" - :inputLabel="t('Add people')" + :inputLabel="t('Add recipient')" :options="results" :loading="searching" :placeholder="t('Name, team, email or federated cloud ID')" @@ -241,17 +241,17 @@ const isDraft = computed(() => props.share.state === 'draft') const invitedRecipients = computed(() => props.share.recipients.filter((recipient) => recipient.class !== RECIPIENT_TYPE_TOKEN)) /** - * Ask before dropping the invited people when switching to a public link. + * Ask before dropping the recipients when switching to a public link. * - * @param count Number of invited people that would be removed + * @param count Number of recipients that would be removed */ async function confirmDropInvited(count: number): Promise { let confirmed = false const dialog = (new DialogBuilder()) .setName(t('Share with anyone')) .setText(n( - 'Switching to a public link removes %n invited person from this share.', - 'Switching to a public link removes %n invited people from this share.', + 'Switching to a public link removes %n recipient from this share.', + 'Switching to a public link removes %n recipients from this share.', count, )) .setButtons([ @@ -278,7 +278,7 @@ async function confirmDropInvited(count: number): Promise { } /** - * Switch the share type. A public link cannot keep invited people, so confirm + * Switch the share type. A public link cannot keep its recipients, so confirm * and remove them first. * * @param tab The tab to switch to diff --git a/tests/ct/RecipientRow.spec.ts b/tests/ct/RecipientRow.spec.ts index 7f68e08..0c224f7 100644 --- a/tests/ct/RecipientRow.spec.ts +++ b/tests/ct/RecipientRow.spec.ts @@ -20,7 +20,7 @@ test('removes the recipient from the menu', async ({ mount, page }) => { } const component = await mount(Fixture, { on: { removed: onRemoved } }) await component.getByRole('button', { name: 'Recipient actions' }).click() - await page.getByRole('menuitem', { name: 'Remove participant' }).click() + await page.getByRole('menuitem', { name: 'Remove recipient' }).click() expect(removed).toBe(true) })