RadioList, CheckboxList: getControlPart() and getLabelPart() throw exception for invalid key

Author: dg

src/Forms/Controls/CheckboxList.php

@@ -10,7 +10,7 @@
 use Nette;
 use Nette\Utils\Html;
 use Stringable;
-use function array_flip, array_key_first, array_keys, array_merge, explode, func_num_args, in_array, is_array, key, substr;
+use function array_flip, array_key_exists, array_key_first, array_keys, array_merge, explode, func_num_args, in_array, is_array, is_string, key, substr;
 
 
 /**
@@ -85,6 +85,10 @@ public function getLabel($caption = null): Html
 	public function getControlPart($key = null): Html
 	{
 		$key = key([(string) $key => null]);
+		if (!array_key_exists($key, $this->getItems())) {
+			throw new Nette\InvalidArgumentException("Item '$key' does not exist in field '{$this->getName()}'.");
+		}
+
 		return parent::getControl()->addAttributes([
 			'id' => $this->getHtmlId() . '-' . $key,
 			'checked' => in_array($key, (array) $this->value, strict: true),
@@ -100,10 +104,17 @@ public function getControlPart($key = null): Html
 	 */
 	public function getLabelPart($key = null): Html
 	{
+		if (!func_num_args()) {
+			return $this->getLabel();
+		}
+
+		$key = key([(string) $key => null]);
+		if (!array_key_exists($key, $this->getItems())) {
+			throw new Nette\InvalidArgumentException("Item '$key' does not exist in field '{$this->getName()}'.");
+		}
+
 		$itemLabel = clone $this->itemLabel;
-		return func_num_args()
-			? $itemLabel->setText($this->translate($this->getItems()[$key]))->for($this->getHtmlId() . '-' . $key)
-			: $this->getLabel();
+		return $itemLabel->setText($this->translate($this->getItems()[$key]))->for($this->getHtmlId() . '-' . $key);
 	}
 
 

src/Forms/Controls/RadioList.php

@@ -10,7 +10,7 @@
 use Nette;
 use Nette\Utils\Html;
 use Stringable;
-use function array_merge, func_num_args, in_array, is_array, key;
+use function array_key_exists, array_key_first, array_merge, func_num_args, in_array, is_array, key;
 
 
 /**
@@ -82,6 +82,10 @@ public function getLabel($caption = null): Html
 	public function getControlPart($key = null): Html
 	{
 		$key = key([(string) $key => null]);
+		if (!array_key_exists($key, $this->getItems())) {
+			throw new Nette\InvalidArgumentException("Item '$key' does not exist in field '{$this->getName()}'.");
+		}
+
 		return parent::getControl()->addAttributes([
 			'id' => $this->getHtmlId() . '-' . $key,
 			'checked' => in_array($key, (array) $this->value, strict: true),
@@ -96,10 +100,17 @@ public function getControlPart($key = null): Html
 	 */
 	public function getLabelPart($key = null): Html
 	{
+		if (!func_num_args()) {
+			return $this->getLabel();
+		}
+
+		$key = key([(string) $key => null]);
+		if (!array_key_exists($key, $this->getItems())) {
+			throw new Nette\InvalidArgumentException("Item '$key' does not exist in field '{$this->getName()}'.");
+		}
+
 		$itemLabel = clone $this->itemLabel;
-		return func_num_args()
-			? $itemLabel->setText($this->translate($this->getItems()[$key]))->for($this->getHtmlId() . '-' . $key)
-			: $this->getLabel();
+		return $itemLabel->setText($this->translate($this->getItems()[$key]))->for($this->getHtmlId() . '-' . $key);
 	}
 
 

tests/Controls/CheckboxList.render.phpt

@@ -190,3 +190,17 @@ test('item label prototype styling', function () {
 	Assert::same('<label class="foo" for="frm-list-a">b</label>', (string) $input->getLabelPart('a'));
 	Assert::same('<label class="foo"><input type="checkbox" name="list[]" value="a">b</label>', (string) $input->getControl());
 });
+
+
+testException('invalid key in getControlPart', function () {
+	$form = new Form;
+	$input = $form->addCheckboxList('list', 'Label', ['a' => 'First']);
+	$input->getControlPart('unknown');
+}, Nette\InvalidArgumentException::class, "Item 'unknown' does not exist in field 'list'.");
+
+
+testException('invalid key in getLabelPart', function () {
+	$form = new Form;
+	$input = $form->addCheckboxList('list', 'Label', ['a' => 'First']);
+	$input->getLabelPart('unknown');
+}, Nette\InvalidArgumentException::class, "Item 'unknown' does not exist in field 'list'.");

tests/Controls/RadioList.render.phpt

@@ -191,3 +191,17 @@ test('radio list control options', function () {
 	$input->getControl();
 	Assert::true($input->getOption('rendered'));
 });
+
+
+testException('invalid key in getControlPart', function () {
+	$form = new Form;
+	$input = $form->addRadioList('list', 'Label', ['a' => 'First']);
+	$input->getControlPart('unknown');
+}, Nette\InvalidArgumentException::class, "Item 'unknown' does not exist in field 'list'.");
+
+
+testException('invalid key in getLabelPart', function () {
+	$form = new Form;
+	$input = $form->addRadioList('list', 'Label', ['a' => 'First']);
+	$input->getLabelPart('unknown');
+}, Nette\InvalidArgumentException::class, "Item 'unknown' does not exist in field 'list'.");