Skip to content

Commit e46feb4

Browse files
committed
fix: app building
1 parent 2b37b6b commit e46feb4

3 files changed

Lines changed: 7 additions & 27 deletions

File tree

cpp/HybridStyleRegistry.cpp

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -16,17 +16,9 @@
1616
// New: dynamic payloads (now handled by ShadowTreeUpdateManager)
1717
#include <folly/dynamic.h>
1818

19-
// React Tag and optional UIManagerBinding (guarded)
19+
// React Tag
2020
#include <react/renderer/core/ReactPrimitives.h> // facebook::react::Tag
2121

22-
#if __has_include(<react/renderer/uimanager/UIManagerBinding.h>)
23-
24-
#include <react/renderer/uimanager/UIManagerBinding.h>
25-
26-
#define HAS_UIMANAGER_BINDING 1
27-
#else
28-
#define HAS_UIMANAGER_BINDING 0
29-
#endif
3022

3123
namespace margelo::nitro::cssnitro {
3224

cpp/ShadowTreeUpdateManager.cpp

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -10,16 +10,8 @@
1010
#include <variant>
1111
#include <functional>
1212
#include <cctype>
13-
14-
#if __has_include(<react/renderer/uimanager/UIManagerBinding.h>)
15-
1613
#include <react/renderer/uimanager/UIManagerBinding.h>
1714

18-
#define HAS_UIMANAGER_BINDING 1
19-
#else
20-
#define HAS_UIMANAGER_BINDING 0
21-
#endif
22-
2315
namespace margelo {
2416
namespace nitro {
2517
namespace cssnitro {
@@ -206,15 +198,11 @@ namespace margelo {
206198

207199
void
208200
ShadowTreeUpdateManager::applyUpdates(Runtime &runtime, const UpdatesMap &updates) {
209-
#if HAS_UIMANAGER_BINDING
210201
if (updates.empty()) return;
211202
auto binding = facebook::react::UIManagerBinding::getBinding(runtime);
212203
if (!binding) return;
213204
auto &uiManager = binding->getUIManager();
214205
uiManager.updateShadowTree(updates);
215-
#else
216-
(void) runtime; (void) updates;
217-
#endif
218206
}
219207

220208
}

src/specs/StyleRegistry/HybridStyleRegistry.nitro.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,12 @@ export interface StyleRegistry
3131
unlinkComponent(componentId: string): void;
3232

3333
/** Computed values */
34-
setWindowDimensions(
35-
width: number,
36-
height: number,
37-
scale: number,
38-
fontScale: number
39-
): void;
34+
// setWindowDimensions(
35+
// width: number,
36+
// height: number,
37+
// scale: number,
38+
// fontScale: number
39+
// ): void;
4040
}
4141

4242
/**

0 commit comments

Comments
 (0)