Skip to content

Use semantic types for registration expiration helpers' input #2352

Description

@tk-o

This issue requires updating all helpers in the packages/ensnode-sdk/src/registrars/registration-expiration.ts file to use semantic types (UnixTimestamp, Duration) instead of native JS types (i.e. bigint).

Please note, that it might not be a straightforward update due to the max allowed expiry value:

/**
* Maximum expiry value for ENSv2 names (2^64 - 1).
* @see https://github.com/ensdomains/contracts-v2/blob/main/contracts/script/deploy-constants.ts
*/
export const MAX_EXPIRY = (1n << 64n) - 1n;

See failing test cases for reference:
https://github.com/namehash/ensnode/actions/runs/29262138543/job/86857912354?pr=2350

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    Fields

    No fields configured for Task.

    Projects

    Status
    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions