From aaf96ce84a490b7e3623e7305635f39251c1095f Mon Sep 17 00:00:00 2001
From: Kevinlee49 <myungeun2dc@gmail.com>
Date: Thu, 3 Sep 2026 22:08:43 -0500
Subject: [PATCH] fix: stop flagging current ask-user hooks as legacy

---
 lib/code-notify/core/config.sh |  2 +-
 tests/test-ask-user-alert.sh   | 29 ++++++++++++++++++++++++++++-
 2 files changed, 29 insertions(+), 2 deletions(-)

diff --git a/lib/code-notify/core/config.sh b/lib/code-notify/core/config.sh
index 7b1cf1e..b1b06a5 100755
--- a/lib/code-notify/core/config.sh
+++ b/lib/code-notify/core/config.sh
@@ -448,7 +448,7 @@ has_legacy_global_claude_hooks() {
 
     grep -q 'claude-notify' "$file" ||
         grep -qE 'notifier\.sh (notification|stop)"' "$file" ||
-        grep -q 'notifier.sh PreToolUse' "$file" ||
+        grep -qE 'notifier\.sh PreToolUse"' "$file" ||
         grep -qE 'notify\.ps1.* (notification|stop)"' "$file" ||
         grep -qE 'notify\.ps1.* PreToolUse' "$file"
 }
diff --git a/tests/test-ask-user-alert.sh b/tests/test-ask-user-alert.sh
index 57433d3..e0e5e83 100644
--- a/tests/test-ask-user-alert.sh
+++ b/tests/test-ask-user-alert.sh
@@ -13,7 +13,7 @@ mkdir -p "$CLAUDE_HOME/notifications"
 
 source "$ROOT_DIR/lib/code-notify/core/config.sh"
 
-notify_script="$test_dir/notify.sh"
+notify_script="$test_dir/notifier.sh"
 get_notify_script() {
     printf '%s\n' "$notify_script"
 }
@@ -54,6 +54,10 @@ set_notify_types "idle_prompt|ask_user"
 enable_hooks_in_settings
 enable_hooks_in_settings
 
+if claude_global_hooks_need_repair; then
+    fail "current ask_user hook was incorrectly flagged as legacy"
+fi
+
 python3 - "$GLOBAL_SETTINGS_FILE" "$notify_script" <<'PYTHON'
 import json
 import sys
@@ -91,6 +95,29 @@ if not any(
     raise SystemExit("custom non-AskUserQuestion PreToolUse hook was not preserved")
 PYTHON
 
+legacy_settings_file="$test_dir/legacy-settings.json"
+cat > "$legacy_settings_file" <<JSON
+{
+  "hooks": {
+    "PreToolUse": [
+      {
+        "matcher": "AskUserQuestion",
+        "hooks": [
+          {
+            "type": "command",
+            "command": "$notify_script PreToolUse"
+          }
+        ]
+      }
+    ]
+  }
+}
+JSON
+
+if ! has_legacy_global_claude_hooks "$legacy_settings_file"; then
+    fail "legacy PreToolUse hook was not flagged for repair"
+fi
+
 unregister_ask_user_hook "$GLOBAL_SETTINGS_FILE" "$(get_global_claude_pre_tool_use_command)"
 
 python3 - "$GLOBAL_SETTINGS_FILE" "$notify_script" <<'PYTHON'