W-12136893: add tests for language level validation (#68)

* W-12136893: add tests for language level validation

Author: andres-rad

native-cli-integration-tests/src/test/scala/org/mule/weave/native/NativeCliITTestRunner.scala

@@ -28,24 +28,27 @@ class NativeCliITTestRunner(args: Array[String])
     dwPath.getAbsolutePath
   }
 
-  def execute(): (Int, String) = {
+  def execute(): (Int, String, String) = {
     execute(5, TimeUnit.SECONDS)
   }
 
-  def execute(timeout: Long, unit: TimeUnit): (Int, String) = {
+  def execute(timeout: Long, unit: TimeUnit): (Int, String, String) = {
     val command = DW_CLI_EXECUTABLE +: args
     println(s"Executing command: ${command.mkString(" ")}")
     val proc = Runtime.getRuntime.exec(command)
     proc.waitFor(timeout, unit)
-    proc.exitValue()
     val source = Source.fromInputStream(proc.getInputStream)
+    val errorStream = Source.fromInputStream(proc.getErrorStream)
     var out = ""
+    var error = ""
     try {
       out = source.mkString.trim
+      error = errorStream.mkString.trim
     } finally {
       source.close()
+      errorStream.close()
     }
-    (proc.exitValue(), out)
+    (proc.exitValue(), out, error)
   }
 }
 

native-cli-integration-tests/src/test/scala/org/mule/weave/native/NativeCliRuntimeIT.scala

@@ -212,7 +212,7 @@ class NativeCliRuntimeIT extends FunSpec
           args = args :+ "-f"
           args = args :+ cliTransform.getAbsolutePath
 
-          val (exitCode, _) = NativeCliITTestRunner(args).execute(TIMEOUT._1, TIMEOUT._2)
+          val (exitCode, _, _) = NativeCliITTestRunner(args).execute(TIMEOUT._1, TIMEOUT._2)
 
           exitCode shouldBe 0
           doAssert(outputPath.toFile, scenario.output, maybeEncoding)

native-cli-integration-tests/src/test/scala/org/mule/weave/native/NativeCliTest.scala

@@ -1,5 +1,6 @@
 package org.mule.weave.native
 
+import org.mule.weave.v2.utils.DataWeaveVersion
 import org.scalatest.BeforeAndAfterAll
 import org.scalatest.FreeSpec
 import org.scalatest.Matchers
@@ -26,7 +27,7 @@ class NativeCliTest extends FreeSpec
   "it should execute simple migration correctly" in {
     val stream: URL = getClass.getClassLoader.getResource("dw1/SimpleFile.dw1")
     val file = new File(stream.toURI)
-    val (_, output) = NativeCliITTestRunner(Array("--migrate", file.getAbsolutePath)).execute()
+    val (_, output, _) = NativeCliITTestRunner(Array("--migrate", file.getAbsolutePath)).execute()
     output.trim shouldBe
       """
         |%dw 2.0
@@ -41,20 +42,34 @@ class NativeCliTest extends FreeSpec
   }
 
   "it should execute simple case correctly" in {
-    val (_, output) = NativeCliITTestRunner("1 to 10").execute()
+    val (_, output, _) = NativeCliITTestRunner("1 to 10").execute()
     output shouldBe "[\n  1,\n  2,\n  3,\n  4,\n  5,\n  6,\n  7,\n  8,\n  9,\n  10\n]"
   }
 
   "it should execute with input" in {
     val path = getResourcePath("inputs/payload.json")
-    val (_, output) = NativeCliITTestRunner(Array("-i", "payload", path, "payload.name")).execute()
+    val (_, output, _) = NativeCliITTestRunner(Array("-i", "payload", path, "payload.name")).execute()
     output shouldBe "\"Tomo\""
   }
 
   "it should execute with input and script" in {
     val inputPath = getResourcePath("inputs/payload.json")
     val transformationPath = getResourcePath("scripts/GetName.dwl")
-    val (_, output) = NativeCliITTestRunner(Array("-i", "payload", inputPath, "-f", transformationPath)).execute()
+    val (_, output, _) = NativeCliITTestRunner(Array("-i", "payload", inputPath, "-f", transformationPath)).execute()
     output shouldBe "\"Tomo\""
   }
+
+  "it should fail if language level is set incorrectly" in {
+    val (exitCode, _, errorMsg) = NativeCliITTestRunner(Array("-language-level", "payload")).execute()
+    exitCode should not be 0
+    errorMsg should include("Unrecognized language level")
+  }
+
+  "should fail if language level is greater than runtime" in {
+    val runtimeLL = DataWeaveVersion()
+    val badLL = s"${runtimeLL.major}.${runtimeLL.minor + 1}"
+    val (exitCode, _, errorMsg) = NativeCliITTestRunner(Array("-language-level", badLL)).execute()
+    exitCode should not be 0
+    errorMsg should include(s"Invalid language level, cannot be higher than ${runtimeLL.toString()}")
+  }
 }

native-cli/src/test/scala/org/mule/weave/dwnative/cli/ArgumentsParserTest.scala

@@ -3,6 +3,8 @@ package org.mule.weave.dwnative.cli
 import org.mule.weave.dwnative.cli.commands.CreateSpellCommand
 import org.mule.weave.dwnative.cli.commands.HelpCommand
 import org.mule.weave.dwnative.cli.commands.RunWeaveCommand
+import org.mule.weave.v2.utils.DataWeaveVersion
+
 import org.scalatest.FreeSpec
 import org.scalatest.Matchers
 
@@ -105,6 +107,24 @@ class ArgumentsParserTest extends FreeSpec with Matchers {
     assert(commandToRun.isInstanceOf[RunWeaveCommand])
   }
 
+  "should fail if language level is badly written" in {
+    val parser = new CLIArgumentsParser(new TestConsole())
+    val value = parser.parse(Array("'Test'", "--language-level", "-2.4"))
+    assert(value.isRight)
+    val message = value.right.get
+    message shouldBe "Unrecognized language level"
+  }
+
+  "should fail if language level is greater than runtime" in {
+    val parser = new CLIArgumentsParser(new TestConsole())
+    val runtimeLL = DataWeaveVersion()
+    val badLL = s"${runtimeLL.major}.${runtimeLL.minor + 1}"
+    val value = parser.parse(Array("'Test'", "--language-level", badLL))
+    assert(value.isRight)
+    val message = value.right.get
+    message shouldBe s"Invalid language level, cannot be higher than ${runtimeLL.toString()}"
+  }
+
   "should fail parsing unrecognized argument" in {
     val parser = new CLIArgumentsParser(new TestConsole())
     val value = parser.parse(Array("-o", "/tmp/out.json", "--parameter", "p1", "p2", "p3", "1 to 10" ))