Merge pull request #319 from Shopify/mark-self-in-packer-unpacker

byroot · web-flow · commit 45bb42996787 · 2023-03-02T14:36:52.000+01:00
diff --git a/ext/msgpack/packer.c b/ext/msgpack/packer.c
@@ -43,6 +43,7 @@ void msgpack_packer_mark(msgpack_packer_t* pk)
     /* See MessagePack_Buffer_wrap */
     /* msgpack_buffer_mark(PACKER_BUFFER_(pk)); */
     rb_gc_mark(pk->buffer_ref);
+    rb_gc_mark(pk->to_msgpack_arg);
 }
 
 void msgpack_packer_reset(msgpack_packer_t* pk)
diff --git a/ext/msgpack/unpacker.c b/ext/msgpack/unpacker.c
@@ -120,6 +120,7 @@ void msgpack_unpacker_mark(msgpack_unpacker_t* uk)
     /* See MessagePack_Buffer_wrap */
     /* msgpack_buffer_mark(UNPACKER_BUFFER_(uk)); */
     rb_gc_mark(uk->buffer_ref);
+    rb_gc_mark(uk->self);
 }
 
 void _msgpack_unpacker_reset(msgpack_unpacker_t* uk)

Original file line number	Diff line number	Diff line change
`@@ -43,6 +43,7 @@ void msgpack_packer_mark(msgpack_packer_t* pk)`
`43`	`43`	`/* See MessagePack_Buffer_wrap */`
`44`	`44`	`/* msgpack_buffer_mark(PACKER_BUFFER_(pk)); */`
`45`	`45`	`rb_gc_mark(pk->buffer_ref);`
	`46`	`+ rb_gc_mark(pk->to_msgpack_arg);`
`46`	`47`	`}`
`47`	`48`
`48`	`49`	`void msgpack_packer_reset(msgpack_packer_t* pk)`
Original file line number	Diff line number	Diff line change
`@@ -120,6 +120,7 @@ void msgpack_unpacker_mark(msgpack_unpacker_t* uk)`
`120`	`120`	`/* See MessagePack_Buffer_wrap */`
`121`	`121`	`/* msgpack_buffer_mark(UNPACKER_BUFFER_(uk)); */`
`122`	`122`	`rb_gc_mark(uk->buffer_ref);`
	`123`	`+ rb_gc_mark(uk->self);`
`123`	`124`	`}`
`124`	`125`
`125`	`126`	`void _msgpack_unpacker_reset(msgpack_unpacker_t* uk)`