Skip to content

Commit cf23a18

Browse files
committed
Fix transport bug and typo
1 parent 4e97076 commit cf23a18

2 files changed

Lines changed: 1 addition & 14 deletions

File tree

msgpackrpc/transport/tcp.py

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -137,28 +137,15 @@ def __init__(self, stream, transport):
137137
BaseSocket.__init__(self, stream)
138138
self._transport = transport
139139
self._stream.read_until_close(self.on_read, self.on_read)
140-
#self._stream.set_close_callback(self.on_close)
141-
142-
#def connect(self):
143-
# self._stream.connect(self._transport._address.unpack(), self.on_connect)
144-
145-
#def on_connect(self):
146-
# self._stream.read_until_close(self.on_read, self.on_read)
147-
# self._transport.on_connect(self)
148-
149-
#def on_connect_failed(self):
150-
# self._transport.on_connect_failed(self)
151140

152141
def on_close(self):
153142
self._transport.on_close(self)
154143

155144
def on_request(self, msgid, method, param):
156145
self._transport._server.on_request(self, msgid, method, param)
157-
self._stream.close()
158146

159147
def on_notify(self, method, param):
160148
self._transport._server.on_request(method, param)
161-
self._stream.close()
162149

163150

164151
class MessagePackServer(netutil.TCPServer):

test/test_msgpackrpc.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ def tearDown(self):
4040

4141
def test_hello(self):
4242
client = self.setup_env();
43-
self.assertEqual(client.call('hello'), "world", "sum result is incorrect")
43+
self.assertEqual(client.call('hello'), "world", "hello result is incorrect")
4444

4545
def test_add(self):
4646
client = self.setup_env();

0 commit comments

Comments
 (0)