From f90c4ed581879bead44a2f3d84e3e98dbc8631e6 Mon Sep 17 00:00:00 2001 From: Christian Fehmer Date: Mon, 26 Oct 2026 23:48:04 +0100 Subject: [PATCH] fix: allow renaming custom theme without updating colors (@fehmer) The update modal's checkbox had no initVal, so SimpleModal seeded the field with undefined. The required z.boolean() schema rejected undefined on submit, so renaming a custom theme without ticking the color-update checkbox died with 'Please fill in all fields'. Seed false (same convention as the DevOptions generate-data modal) so the field is a real boolean from birth. --- .../src/ts/components/pages/settings/custom-setting/Theme.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/frontend/src/ts/components/pages/settings/custom-setting/Theme.tsx b/frontend/src/ts/components/pages/settings/custom-setting/Theme.tsx index 8136b64d7280..d567de56413e 100644 --- a/frontend/src/ts/components/pages/settings/custom-setting/Theme.tsx +++ b/frontend/src/ts/components/pages/settings/custom-setting/Theme.tsx @@ -358,6 +358,7 @@ function CustomThemeButton(props: { theme: CustomTheme }): JSXElement { }, updateColors: { type: "checkbox", + initVal: false, label: "Update custom theme to current colors", }, },