WooCommerce/phpcs.transition.xml.dist at dev/develop · mollie/WooCommerce · GitHub

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
<?xml version="1.0"?>
<ruleset name="Mollie Transition">

    <description>
        Temporary ruleset on top of phpcs.xml.dist. Relaxes rules that inpsyde/php-coding-standards v2
        introduced with no v1 equivalent, so the codebase isn't held hostage to a large-scale reformat
        just to unblock the v1->v2 security-driven dependency bump. Drop this file and switch back to
        phpcs.xml.dist once the codebase is deliberately migrated to full v2 compliance.
    </description>

    <rule ref="./phpcs.xml.dist"/>

    <!-- New in v2, error-level, no v1 equivalent -->
    <rule ref="PSR12.Properties.ConstantVisibility"><severity>0</severity></rule>
    <rule ref="SlevomatCodingStandard.TypeHints.DeclareStrictTypes"><severity>0</severity></rule>
    <rule ref="SlevomatCodingStandard.TypeHints.PropertyTypeHint"><severity>0</severity></rule>
    <rule ref="Generic.Formatting.SpaceAfterCast"><severity>0</severity></rule>
    <rule ref="Generic.Formatting.SpaceAfterNot"><severity>0</severity></rule>
    <rule ref="Generic.WhiteSpace.LanguageConstructSpacing"><severity>0</severity></rule>
    <rule ref="Generic.WhiteSpace.SpreadOperatorSpacingAfter"><severity>0</severity></rule>
    <rule ref="Universal.WhiteSpace.PrecisionAlignment"><severity>0</severity></rule>
    <rule ref="WordPress.CodeAnalysis.AssignmentInTernaryCondition"><severity>0</severity></rule>

    <!-- New in v2, warning-level, no v1 equivalent (silenced so phpcbf doesn't reformat to the new style) -->
    <rule ref="SlevomatCodingStandard.Arrays.SingleLineArrayWhitespace"><severity>0</severity></rule>
    <rule ref="SlevomatCodingStandard.Functions.ArrowFunctionDeclaration"><severity>0</severity></rule>
    <rule ref="SlevomatCodingStandard.Whitespaces.DuplicateSpaces"><severity>0</severity></rule>
    <rule ref="Squiz.Arrays.ArrayBracketSpacing"><severity>0</severity></rule>
    <rule ref="Squiz.Functions.MultiLineFunctionDeclaration"><severity>0</severity></rule>
    <rule ref="Squiz.WhiteSpace.FunctionSpacing"><severity>0</severity></rule>
    <rule ref="Generic.WhiteSpace.ArbitraryParenthesesSpacing"><severity>0</severity></rule>
    <rule ref="PSR12.Operators.OperatorSpacing.NoSpaceBefore"><severity>0</severity></rule>

    <!--
    Pre-existing findings, unrelated to the v1->v2 bump (same in both versions), deferred as
    deliberate follow-up work rather than fixed as a side effect of unblocking CI.
    -->
    <!-- inc/utils.php and inc/woocommerce.php contain legacy global functions; namespacing them
    means updating every call site across the codebase. -->
    <rule ref="Inpsyde.CodeQuality.NoRootNamespaceFunctions"><severity>0</severity></rule>
    <!-- MolliePaymentGatewayHandler::$enabled/$id intentionally mirror WC_Payment_Gateway's own
    public-property contract and are duck-typed against elsewhere; not a real code smell here. -->
    <rule ref="Inpsyde.CodeQuality.ForbiddenPublicProperty"><severity>0</severity></rule>

</ruleset>