Skip to content

Commit 216bbf6

Browse files
authored
refactor: remove typecheck configurations and related tsconfig files (#141)
By doing this we are reducing the amount of Typechecks we are running down from 2, to 1. This will speedup the CI pipeline by a small margin. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Removed package-specific TypeScript test configuration files. - Updated test configuration to eliminate type checking for test declaration files in several packages. - Adjusted CI workflow to change the order of type checking in the process. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
2 parents 27e253e + e7d5b46 commit 216bbf6

8 files changed

Lines changed: 3 additions & 56 deletions

File tree

.github/workflows/ci.yaml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,12 @@ jobs:
3636
- name: lint
3737
run: pnpm lint
3838

39+
- name: typecheck
40+
run: pnpm typecheck
41+
3942
- name: test
4043
run: pnpm test --coverage
4144

42-
- name: typecheck
43-
run: pnpm typecheck
4445

4546
- name: upload coverage reports to codecov
4647
uses: codecov/codecov-action@0565863a31f2c772f9f0395002a31e3f06189574 # v5.4.0

packages/adapters/tsconfig.test.json

Lines changed: 0 additions & 4 deletions
This file was deleted.

packages/cli/tsconfig.test.json

Lines changed: 0 additions & 4 deletions
This file was deleted.

packages/internal-utils/tsconfig.test.json

Lines changed: 0 additions & 4 deletions
This file was deleted.

packages/parsers/tsconfig.test.json

Lines changed: 0 additions & 4 deletions
This file was deleted.

packages/schemas/tsconfig.test.json

Lines changed: 0 additions & 4 deletions
This file was deleted.

packages/versions/tsconfig.test.json

Lines changed: 0 additions & 4 deletions
This file was deleted.

vitest.config.ts

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -47,12 +47,6 @@ export default defineConfig({
4747
name: "internal-utils",
4848
environment: "node",
4949
mockReset: true,
50-
typecheck: {
51-
checker: "tsc",
52-
enabled: true,
53-
include: ["./packages/internal-utils/**/*.{test,spec}-d.?(c|m)[jt]s?(x)"],
54-
tsconfig: "./packages/internal-utils/tsconfig.test.json"
55-
}
5650
},
5751
esbuild: { target: "es2020" },
5852
resolve: { alias: aliases },
@@ -65,12 +59,6 @@ export default defineConfig({
6559
name: "adapters",
6660
environment: "node",
6761
mockReset: true,
68-
typecheck: {
69-
checker: "tsc",
70-
enabled: true,
71-
include: ["./packages/adapters/**/*.{test,spec}-d.?(c|m)[jt]s?(x)"],
72-
tsconfig: "./packages/adapters/tsconfig.test.json"
73-
}
7462
},
7563
esbuild: { target: "es2020" },
7664
resolve: { alias: aliases },
@@ -82,12 +70,6 @@ export default defineConfig({
8270
name: "cli",
8371
environment: "node",
8472
mockReset: true,
85-
typecheck: {
86-
checker: "tsc",
87-
enabled: true,
88-
include: ["./packages/cli/**/*.{test,spec}-d.?(c|m)[jt]s?(x)"],
89-
tsconfig: "./packages/cli/tsconfig.test.json"
90-
}
9173
},
9274
esbuild: { target: "es2020" },
9375
resolve: { alias: aliases },
@@ -99,12 +81,6 @@ export default defineConfig({
9981
name: "parsers",
10082
environment: "node",
10183
mockReset: true,
102-
typecheck: {
103-
checker: "tsc",
104-
enabled: true,
105-
include: ["./packages/parsers/**/*.{test,spec}-d.?(c|m)[jt]s?(x)"],
106-
tsconfig: "./packages/parsers/tsconfig.test.json"
107-
}
10884
},
10985
esbuild: { target: "es2020" },
11086
resolve: { alias: aliases },
@@ -116,12 +92,6 @@ export default defineConfig({
11692
name: "schemas",
11793
environment: "node",
11894
mockReset: true,
119-
typecheck: {
120-
checker: "tsc",
121-
enabled: true,
122-
include: ["./packages/schemas/**/*.{test,spec}-d.?(c|m)[jt]s?(x)"],
123-
tsconfig: "./packages/schemas/tsconfig.test.json"
124-
}
12595
},
12696
esbuild: { target: "es2020" },
12797
resolve: { alias: aliases },

0 commit comments

Comments
 (0)