Skip to content

Commit f7cd2d7

Browse files
authored
Change syncing of dependencies with README (#13832)
1 parent bd6f9cc commit f7cd2d7

4 files changed

Lines changed: 10 additions & 34 deletions

File tree

.github/workflows/spec_zero.yml

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,12 @@ jobs:
4646
version: ">=0.9"
4747
activate-environment: true
4848
python-version: 3.12
49-
- run: uv pip install packaging requests tomlkit
50-
- run: python ./tools/dev/spec_zero_update_versions.py
49+
- name: Install dependencies
50+
run: uv pip install -e . packaging requests tomlkit
51+
- name: Update tracked dependencies
52+
run: python ./tools/dev/spec_zero_update_versions.py
53+
- name: Sync updated dependencies to README
54+
run: python tools/sync_dependencies.py
5155
- name: Create lockfile for old CI
5256
# uv pip compile requires setting the python version explicitly in the command :(
5357
run: |
@@ -72,7 +76,9 @@ jobs:
7276
git config --global user.email "50266005+mne-bot@users.noreply.github.com"
7377
git config --global user.name "mne[bot]"
7478
git checkout -b spec_zero
75-
git add doc/changes/dev/dependency.rst # one new file, others changed
79+
if [ -f doc/changes/dev/dependency.rst ]; then
80+
git add doc/changes/dev/dependency.rst # one new file, others changed
81+
fi
7682
git commit -am "mne[bot]: Update dependency specifiers"
7783
git push origin spec_zero
7884
PR_NUM=$(gh pr create --base main --head spec_zero --title "MAINT: Update dependency specifiers" --body "Created by spec_zero [GitHub action](https://github.com/mne-tools/mne-python/actions/runs/${{ github.run_id }}). <br> <br> *Adjustments may need to be made to shims in \`mne/fixes.py\` and elswhere in this or another PR. \`make -C tools/dev dep\` is a good starting point for finding potential updates.*")

.pre-commit-config.yaml

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -71,14 +71,6 @@ repos:
7171
language: python
7272
entry: ./tools/hooks/update_environment_file.py
7373
files: '^(pyproject.toml|tools/hooks/update_environment_file.py)$'
74-
- repo: local
75-
hooks:
76-
- id: dependency-sync
77-
name: Copy core dependencies from pyproject.toml to README.rst
78-
language: python
79-
entry: ./tools/hooks/sync_dependencies.py
80-
files: '^(pyproject.toml|tools/hooks/sync_dependencies.py)$'
81-
additional_dependencies: ["mne==1.12.0"]
8274

8375
# zizmor
8476
- repo: https://github.com/woodruffw/zizmor-pre-commit
@@ -89,10 +81,6 @@ repos:
8981
# We correctly use pull_request_trigger, and need Zizmor 2.0+ to configure the ignore
9082
exclude: ^.github/workflows/automerge.yml
9183

92-
# these should *not* be run on CIs:
93-
ci:
94-
skip: [dependency-sync] # needs MNE to work, which exceeds the free tier space alloc.
95-
9684
# The following are too slow to run on local commits, so let's only run on CIs:
9785
#
9886
# - repo: https://github.com/pre-commit/mirrors-mypy

tools/environment_old.yml

Lines changed: 0 additions & 18 deletions
This file was deleted.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
from mne.utils import _pl, warn
1717

18-
README_PATH = Path(__file__).parents[2] / "README.rst"
18+
README_PATH = Path(__file__).parents[1] / "README.rst"
1919
BEGIN = ".. ↓↓↓ BEGIN CORE DEPS LIST. DO NOT EDIT! HANDLED BY PRE-COMMIT HOOK ↓↓↓"
2020
END = ".. ↑↑↑ END CORE DEPS LIST. DO NOT EDIT! HANDLED BY PRE-COMMIT HOOK ↑↑↑"
2121

0 commit comments

Comments
 (0)