eyetrack should not count as picks=data (#13723)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Scott Huberty <52462026+scott-huberty@users.noreply.github.com>

Author: 3 people

doc/changes/dev/13723.bugfix.rst

@@ -0,0 +1 @@
+Change default-pick 'data' for "eyegaze" to false, following existing documentation. by :newcontrib:`Benedikt Ehinger`.

doc/changes/names.inc

@@ -37,6 +37,7 @@
 .. _Austin Hurst: https://github.com/a-hurst
 .. _Beige Jin: https://github.com/BeiGeJin
 .. _Ben Beasley: https://github.com/musicinmybrain
+.. _Benedikt Ehinger: https://www.benediktehinger.de
 .. _Bradley Voytek: https://github.com/voytek
 .. _Britta Westner: https://britta-wstnr.github.io
 .. _Bruno Aristimunha: https://bruaristimunha.github.io

mne/_fiff/pick.py

@@ -1093,7 +1093,7 @@ def _check_excludes_includes(chs, info=None, allow_bads=False):
     dbs=True,
     temperature=False,
     gsr=False,
-    eyetrack=True,
+    eyetrack=False,
 )
 _PICK_TYPES_KEYS = tuple(list(_PICK_TYPES_DATA_DICT) + ["ref_meg"])
 _MEG_CH_TYPES_SPLIT = ("mag", "grad", "planar1", "planar2")

mne/io/eyelink/tests/test_eyelink.py

@@ -10,7 +10,7 @@
 
 from mne import find_events
 from mne._fiff.constants import FIFF
-from mne._fiff.pick import _DATA_CH_TYPES_SPLIT
+from mne._fiff.pick import _DATA_CH_TYPES_SPLIT, _PICK_TYPES_DATA_DICT
 from mne.datasets.testing import data_path, requires_testing_data
 from mne.io import read_raw_eyelink
 from mne.io.eyelink._utils import _adjust_times, _find_overlaps
@@ -45,6 +45,7 @@ def test_eyetrack_not_data_ch():
     )
     assert "eyegaze" not in _DATA_CH_TYPES_SPLIT, msg
     assert "pupil" not in _DATA_CH_TYPES_SPLIT, msg
+    assert not _PICK_TYPES_DATA_DICT["eyetrack"], msg
 
 
 @requires_testing_data

mne/viz/tests/test_evoked.py

@@ -466,7 +466,7 @@ def test_plot_compare_evokeds(evoked):
     plt.close("all")  # close the previous figures as to avoid a too many figs warning
     info_tmp = mne.create_info(["pupil_left"], evoked.info["sfreq"], ["pupil"])
     evoked_et = mne.EvokedArray(np.ones_like(evoked.times).reshape(1, -1), info_tmp)
-    figs = plot_compare_evokeds(evoked_et, show_sensors=False)
+    figs = plot_compare_evokeds(evoked_et, show_sensors=False, picks="eyetrack")
     assert len(figs) == 1
     # test plotting only invalid channel types
     info_tmp = mne.create_info(["ias"], evoked.info["sfreq"], ["ias"])