fix an issue if timetable returns only one flight

Author: mkorkmaz

src/SDK/Helper/GetTimetableHelper.php

@@ -15,7 +15,8 @@ public function __construct(array $responseData)
     public function getFlightExtraInfo() : array
     {
         $extraOTAAirScheduleRS = $this->responseData['extendedOTAAirScheduleRS']['extraOTAAirScheduleRS'];
-        $flightExtraInfo = $extraOTAAirScheduleRS['extraOTAAirScheduleRSListType']['flightExtraInfo'][0];
+        $flightExtraInfo = $this
+            ->getFlightExtraInfoData($extraOTAAirScheduleRS['extraOTAAirScheduleRSListType']['flightExtraInfo']);
         return [
             'totalDuration' => DurationConverter::toMinute($flightExtraInfo['totalDuration']),
             'flightDuration' => DurationConverter::toMinute($flightExtraInfo['flightDuration']),
@@ -24,9 +25,20 @@ public function getFlightExtraInfo() : array
         ];
     }
 
+    private function getFlightExtraInfoData($flightExtraInfo) : array
+    {
+        if (array_key_exists('totalDuration', $flightExtraInfo)) {
+            return $flightExtraInfo;
+        }
+        return $flightExtraInfo[0];
+    }
+
     public function getOriginDestinationOptions() : array
     {
         $airScheduleRS = $this->responseData['extendedOTAAirScheduleRS']['OTA_AirScheduleRS'];
+        if (array_key_exists('FlightSegment', $airScheduleRS['OriginDestinationOptions']['OriginDestinationOption'])) {
+            return [$airScheduleRS['OriginDestinationOptions']['OriginDestinationOption']];
+        }
         return $airScheduleRS['OriginDestinationOptions']['OriginDestinationOption'];
     }
 

tests/unit/Helper/GetTimetableHelperSingleResultTest.php

@@ -0,0 +1,78 @@
+<?php namespace Helper;
+
+use TK\SDK\ClientBuilder;
+use DateTimeImmutable;
+use TK\SDK\Helper\GetTimetableHelper;
+use TK\SDK\ValueObject;
+use Dotenv;
+
+class GetTimetableHelperSingleResultTest extends \Codeception\Test\Unit
+{
+    /**
+     * @var \UnitTester
+     */
+    protected $tester;
+    private $response;
+    
+    protected function _before()
+    {
+        if (file_exists(__DIR__.'/../../../.env')) {
+            $dotenv = new Dotenv\Dotenv(__DIR__ . '/../../..');
+            $dotenv->load();
+        }
+        $client = ClientBuilder::create()
+            ->setEnvironment(getenv('TK_API_URL'), getenv('TK_API_KEY'), getenv('TK_API_SECRET'))
+            ->build();
+        $departureTime = gmdate('Y-m-d H:i:s', strtotime('+4 days'));
+        $originLocation = new ValueObject\Location('IST', ValueObject\Location::MULTIPLE_AIRPORT_TRUE);
+        $destinationLocation  = new ValueObject\Location('BOG', ValueObject\Location::MULTIPLE_AIRPORT_TRUE);
+        $departureDateTime = new ValueObject\DepartureDateTime(
+            new DateTimeImmutable($departureTime),
+            'P3D',
+            'P3D'
+        );
+        $originDestinationInformation = new ValueObject\OriginDestinationInformation(
+            $departureDateTime,
+            $originLocation,
+            $destinationLocation
+        );
+        $airScheduleRQ = (new ValueObject\AirScheduleRQ($originDestinationInformation))
+            ->withDirectAndNonStopOnlyInd();
+        $getTimetableParameters = new ValueObject\GetTimetableParameters(
+            $airScheduleRQ,
+            ValueObject\GetTimetableParameters::SCHEDULE_TYPE_WEEKLY,
+            ValueObject\GetTimetableParameters::TRIP_TYPE_ONE_WAY
+        );
+        $this->response = $client->getTimetable($getTimetableParameters);
+    }
+
+    protected function _after()
+    {
+    }
+
+    /**
+     * @test
+     */
+    public function shouldGetDataSuccessfully() : void
+    {
+        $helper = new GetTimetableHelper($this->response['data']);
+        $flightInfo = $helper->getFlightExtraInfo();
+        $this->assertArrayHasKey('durationType', $flightInfo);
+
+        $originDestinationOptions = $helper->getOriginDestinationOptions();
+
+        foreach ($originDestinationOptions as $originDestinationOption) {
+            $flightDetails = $helper->getFlightDetails($originDestinationOption);
+
+            $this->assertArrayHasKey('FlightNumber', $flightDetails);
+            $this->assertArrayHasKey('DepartureDateTime', $flightDetails);
+            $this->assertArrayHasKey('OperationTime', $flightDetails);
+            $this->assertArrayHasKey('ScheduleValidEndDate', $flightDetails);
+
+
+            $operationAirline = $helper->getOperationAirline($originDestinationOption);
+            $this->assertArrayHasKey('FlightNumber', $operationAirline);
+            $this->assertArrayHasKey('Code', $operationAirline);
+        }
+    }
+}

tests/unit/Helper/GetTimetableHelperTest.php

@@ -25,7 +25,7 @@ protected function _before()
             ->build();
         $departureTime = gmdate('Y-m-d H:i:s', strtotime('+4 days'));
         $originLocation = new ValueObject\Location('IST', ValueObject\Location::MULTIPLE_AIRPORT_TRUE);
-        $destinationLocation  = new ValueObject\Location('ESB', ValueObject\Location::MULTIPLE_AIRPORT_TRUE);
+        $destinationLocation  = new ValueObject\Location('JFK', ValueObject\Location::MULTIPLE_AIRPORT_TRUE);
         $departureDateTime = new ValueObject\DepartureDateTime(
             new DateTimeImmutable($departureTime),
             'P3D',