Fix init/render timing issues

#68 (comment)
RaspberryPiFoundation/blockly#7777
RaspberryPiFoundation/blockly#6786
https://developers.google.com/blockly/guides/contribute/core-architecture/render-management
Co-Authored-By: TannerGabriel <40315960+TannerGabriel@users.noreply.github.com>

Author: mjgallag

block-lexical-variables/src/blocks/lexical-variables.js

@@ -282,16 +282,10 @@ Blockly.Blocks['local_declaration_statement'] = {
     // list. [lyn, 03/04/13] As of change to, Blockly 1636, there is no longer
     // a collapsed input at end.
 
-    // Remember last (= body) input
-    const bodyInput = this.inputList[this.inputList.length - 1]; // Body input
     // for local
     // declaration
     const numDecls = this.inputList.length - 1;
 
-    // [lyn, 07/03/14] stop rendering until block is recreated
-    const savedRendered = this.rendered;
-    this.rendered = false;
-
     // Modify this local-in-do block according to arrangement of name blocks in
     // mutator editor. Remove all the local declaration inputs ...
     const thisBlock = this; // Grab correct object for use in thunk below
@@ -305,9 +299,7 @@ Blockly.Blocks['local_declaration_statement'] = {
         },
     );
 
-    // Empty the inputList and recreate it, building local initializers from
-    // mutator
-    this.inputList = [];
+    // Build local initializers from mutator
     this.localNames_ = names;
 
     for (let i = 0; i < names.length; i++) {
@@ -331,13 +323,7 @@ Blockly.Blocks['local_declaration_statement'] = {
     }
 
     // Now put back last (= body) input
-    this.inputList = this.inputList.concat(bodyInput);
-
-    this.rendered = savedRendered;
-    if (this.rendered) {
-      this.initSvg();
-      this.render();
-    }
+    this.moveInputBefore(this.bodyInputName);
   },
   // [lyn, 10/27/13] Introduced this to correctly handle renaming of mutatorarg
   // in open mutator when procedure parameter flydown name is edited.
@@ -421,17 +407,7 @@ Blockly.Blocks['local_declaration_statement'] = {
     // Reconstruct inputs only if local list has changed
     if (!LexicalVariable.stringListsEqual(this.localNames_,
         newLocalNames)) {
-      // Switch off rendering while the block is rebuilt.
-      // var savedRendered = this.rendered;
-      // this.rendered = false;
-
       this.updateDeclarationInputs_(newLocalNames, initializers);
-
-      // Restore rendering and show the changes.
-      // this.rendered = savedRendered;
-      // if (this.rendered) {
-      //  this.render();
-      // }
     }
   },
   saveConnections: function(containerBlock) {

block-lexical-variables/src/blocks/procedures.js

@@ -166,17 +166,6 @@ Blockly.Blocks['procedures_defnoreturn'] = {
     }
 
     const procName = this.getFieldValue('NAME');
-    // save the first two input lines and the last input line
-    // to be re added to the block later
-    // var firstInput = this.inputList[0];
-    // [lyn, 10/24/13] need to reconstruct first input
-
-    // Body of procedure
-    const bodyInput = this.inputList[this.inputList.length - 1];
-
-    // stop rendering until block is recreated
-    const savedRendered = this.rendered;
-    this.rendered = false;
 
     // remove first input
     // console.log("updateParams_: remove input HEADER");
@@ -213,9 +202,6 @@ Blockly.Blocks['procedures_defnoreturn'] = {
       }
     }
 
-    // empty the inputList then recreate it
-    this.inputList = [];
-
     // console.log("updateParams_: create input HEADER");
     const headerInput = this.createHeader(procName);
     // const headerInput =
@@ -241,24 +227,9 @@ Blockly.Blocks['procedures_defnoreturn'] = {
       }
     }
 
-    // put the last two arguments back
-    this.inputList = this.inputList.concat(bodyInput);
+    // Now put back last (= body) input
+    this.moveInputBefore(this.bodyInputName);
 
-    this.rendered = savedRendered;
-    // [lyn, 10/28/13] I thought this rerendering was unnecessary. But I was
-    // wrong! Without it, get bug noticed by Andrew in which toggling
-    // horizontal -> vertical params in procedure decl doesn't handle body tag
-    // appropriately!
-    for (let i = 0; i < this.inputList.length; i++) {
-      if (this.inputList[i].sourceBlock.rendered) {
-        this.inputList[i].init();
-      } else {
-        this.inputList[i].initModel();
-      }
-    }
-    if (this.rendered) {
-      this.render();
-    }
     // set in BlocklyPanel.java on successful load
     if (this.workspace.loadCompleted) {
       Blockly.Procedures.mutateCallers(this);
@@ -893,9 +864,6 @@ Blockly.Blocks['procedures_callnoreturn'] = {
         this.quarkArguments_ = [];
       }
     }
-    // Switch off rendering while the block is rebuilt.
-    const savedRendered = this.rendered;
-    this.rendered = false;
     // Update the quarkConnections_ with existing connections.
     for (x = 0; this.getInput('ARG' + x); x++) {
       input = this.getInput('ARG' + x);
@@ -933,20 +901,6 @@ Blockly.Blocks['procedures_callnoreturn'] = {
         }
       }
     }
-    // Restore rendering and show the changes.
-    this.rendered = savedRendered;
-    if (!this.workspace.rendered) {
-      // workspace hasn't been rendered yet, so other connections may
-      // not yet exist.
-      return;
-    }
-    // Initialize the new inputs.
-    for (x = 0; x < this.arguments_.length; x++) {
-      this.getInput('ARG' + x).init();
-    }
-    if (this.rendered) {
-      this.render();
-    }
   },
   mutationToDom: function() {
     // Save the name and arguments (none of which are editable).