Fix package manager review suggestions

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 5aba47cf-0b43-48b9-bc22-75e625da70e8

Author: edvilme

src/managers/builtin/pipPackageManager.ts

@@ -145,8 +145,9 @@ export class PipPackageManager implements PackageManager, Disposable {
                 this.log.error('Error managing packages', e);
                 if (!options.runHeadless) {
                     setImmediate(async () => {
-                        const result = await showErrorMessage('Error managing packages', 'View Output');
-                        if (result === 'View Output') {
+                        const viewOutput = l10n.t('View Output');
+                        const result = await showErrorMessage(l10n.t('Error managing packages'), viewOutput);
+                        if (result === viewOutput) {
                             this.log.show();
                         }
                     });
@@ -178,7 +179,7 @@ export class PipPackageManager implements PackageManager, Disposable {
         await withProgress(
             {
                 location: ProgressLocation.Window,
-                title: 'Refreshing packages',
+                title: l10n.t('Refreshing packages'),
             },
             async () => {
                 const packages = await updatePackagesAndNotify(
@@ -226,9 +227,10 @@ export class PipPackageManager implements PackageManager, Disposable {
             this.log.error('Error refreshing packages', error);
             if (showErrors) {
                 setImmediate(async () => {
-const viewOutput = l10n.t('View Output');
+                    const viewOutput = l10n.t('View Output');
                     const result = await showErrorMessage(l10n.t('Error refreshing packages'), viewOutput);
                     if (result === viewOutput) {
+                        this.log.show();
                     }
                 });
             }
@@ -282,9 +284,9 @@ const viewOutput = l10n.t('View Output');
 
         // For pip < 21.2.0, check version first.
         if (availableVersionsCmd instanceof PipAvailableVersionsCommand) {
-const pipVersionCmd = new PipVersionCommand({ pythonExecutable, log: this.log });
-            const pipVersion = await pipVersionCmd.execute();
+            const pipVersion = await new PipVersionCommand({ pythonExecutable, log: this.log }).execute();
             if (!pipVersion) {
+                throw new Error(`Unable to determine pip version for environment: ${environment.envId.id}`);
             }
             if (compare(pipVersion.public, '21.2.0') < 0) {
                 throw new PackageVersionLookupNotSupportedError(

src/managers/builtin/pipUtils.ts

@@ -286,10 +286,7 @@ export async function getWorkspacePackagesToInstall(
                     PipListCommand,
                     UvListCommand,
                 );
-const data = await withProgress(
-                    { location: ProgressLocation.Notification },
-                    () => listCmd.execute(),
-                );
+                const data = await withProgress({ location: ProgressLocation.Notification }, () => listCmd.execute());
                 installed = data.map((pkg) => pkg.name);
             } catch (error) {
                 log?.error('Error listing installed packages', error);

src/test/managers/builtin/pipPackageManager.unit.test.ts

@@ -95,6 +95,31 @@ suite('PipPackageManager', () => {
         );
     });
 
+    test('propagates pip version command failures during version lookup', async () => {
+        const manager = createManager();
+        const environment = createEnvironment();
+        const versionError = new Error('pip version failed');
+        sinon.stub(helpers, 'shouldUseUv').resolves(false);
+        sinon.stub(helpers, 'runPython').rejects(versionError);
+
+        await assert.rejects(
+            manager.getPackageAvailableVersions(environment, 'requests'),
+            (error: unknown) => error === versionError,
+        );
+    });
+
+    test('rejects version lookup when pip version output cannot be parsed', async () => {
+        const manager = createManager();
+        const environment = createEnvironment();
+        sinon.stub(helpers, 'shouldUseUv').resolves(false);
+        sinon.stub(helpers, 'runPython').resolves('unexpected version output');
+
+        await assert.rejects(
+            manager.getPackageAvailableVersions(environment, 'requests'),
+            /Unable to determine pip version for environment: test-environment/,
+        );
+    });
+
     test('normalizes discovered Python versions for pip lookup', async () => {
         const manager = createManager();
         const environment = {

src/test/managers/builtin/pipUtils.unit.test.ts

@@ -1,7 +1,7 @@
 import assert from 'assert';
 import * as path from 'path';
 import * as sinon from 'sinon';
-import { CancellationToken, LogOutputChannel, Progress, ProgressOptions, Uri } from 'vscode';
+import { CancellationToken, LogOutputChannel, Progress, ProgressLocation, ProgressOptions, Uri } from 'vscode';
 import * as fse from 'fs-extra';
 import * as os from 'os';
 import { PythonEnvironment, PythonEnvironmentApi, PythonProject } from '../../../api';
@@ -87,6 +87,35 @@ suite('Pip Utils - getProjectInstallable', () => {
             assert.ok(logError.calledOnceWithExactly('Error listing installed packages', listError));
             assert.ok(showQuickPick.calledOnce, 'The package picker should still open after a list failure');
         });
+
+        test('shows progress while listing installed packages', async () => {
+            const environment = {
+                environmentPath: Uri.file('.'),
+                execInfo: { run: { executable: 'python' } },
+            } as PythonEnvironment;
+            const workspacePath = Uri.file('/test/path/root').fsPath;
+            findFilesStub.callsFake((pattern: string) =>
+                Promise.resolve(
+                    pattern === '*requirements*.txt'
+                        ? [Uri.file(path.join(workspacePath, 'requirements.txt'))]
+                        : [],
+                ),
+            );
+            sinon.stub(helpers, 'shouldUseUv').resolves(false);
+            sinon.stub(PipListCommand.prototype, 'execute').resolves([]);
+            const showQuickPick = sinon.stub(winapi, 'showQuickPickWithButtons').resolves(undefined);
+
+            await getWorkspacePackagesToInstall(
+                mockApi as PythonEnvironmentApi,
+                { install: [] },
+                [{ name: 'workspace', uri: Uri.file(workspacePath) }],
+                environment,
+            );
+
+            assert.strictEqual(withProgressStub.callCount, 2);
+            assert.strictEqual(withProgressStub.secondCall.args[0].location, ProgressLocation.Notification);
+            assert.ok(withProgressStub.secondCall.calledBefore(showQuickPick.firstCall));
+        });
     });
 
     teardown(() => {