Skip to content

Commit fce07ca

Browse files
fix(deps): remove unused pyee runtime dependency
Fixes: #3312
1 parent 8ff9ba6 commit fce07ca

4 files changed

Lines changed: 10 additions & 5 deletions

File tree

‎local-requirements.txt‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ objgraph==3.7.0
66
Pillow==12.3.0
77
pixelmatch==0.3.0
88
pre-commit==3.5.0
9+
pyee==13.0.1
910
pyOpenSSL==26.0.0
1011
pytest==9.0.3
1112
pytest-asyncio==1.4.1

‎pyproject.toml‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ requires-python = ">=3.10"
1616
# - pip install uv==0.5.4
1717
# - uv pip compile pyproject.toml -o requirements.txt
1818
dependencies = [
19-
"pyee>=13,<15",
2019
"greenlet>=3.1.1,<4.0.0"
2120
]
2221
classifiers = [

‎requirements.txt‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,3 @@
22
# uv pip compile pyproject.toml -o requirements.txt
33
greenlet==3.5.6
44
# via playwright (pyproject.toml)
5-
pyee==13.0.1
6-
# via playwright (pyproject.toml)
7-
typing-extensions==4.16.0
8-
# via pyee

‎tests/test_installation.py‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ def _run_client(python: str, tmp_path: Path, browser_name: str, environ: dict) -
4949
# of a test.
5050
@pytest.mark.timeout(900)
5151
def test_install(tmp_path: Path, browser_name: str) -> None:
52+
# Regression test for https://github.com/microsoft/playwright-python/issues/3312.
5253
python = _create_venv(tmp_path / "env")
5354
if sys.platform == "win32":
5455
wheelpath = list((ROOT / "dist").glob("playwright*win_amd64*.whl"))[0]
@@ -57,6 +58,14 @@ def test_install(tmp_path: Path, browser_name: str) -> None:
5758
elif sys.platform == "darwin":
5859
wheelpath = list((ROOT / "dist").glob("playwright*macosx_*.whl"))[0]
5960
subprocess.check_output([python, "-m", "pip", "install", str(wheelpath)])
61+
subprocess.check_output(
62+
[
63+
python,
64+
"-c",
65+
"import importlib.util; assert importlib.util.find_spec('pyee') is None",
66+
],
67+
cwd=tmp_path,
68+
)
6069
environ = os.environ.copy()
6170
environ["PLAYWRIGHT_BROWSERS_PATH"] = str(tmp_path)
6271
_run_client(python, tmp_path, browser_name, environ)

0 commit comments

Comments
 (0)