fix(video): return pathlib.Path from Video.path() (#3197)

Author: MohammedAlkindi

playwright/_impl/_video.py

@@ -40,7 +40,7 @@ async def path(self) -> pathlib.Path:
             )
         if not self._artifact:
             raise Error("Video recording has not been started.")
-        return self._artifact.absolute_path
+        return pathlib.Path(self._artifact.absolute_path)
 
     async def save_as(self, path: Union[str, pathlib.Path]) -> None:
         if self._page._connection._is_sync and not self._page._is_closed:

tests/async/test_video.py

@@ -27,6 +27,7 @@ async def test_should_expose_video_path(
     await page.goto(server.PREFIX + "/grid.html")
     assert page.video
     path = await page.video.path()
+    assert isinstance(path, Path)
     assert str(tmp_path) in str(path)
     await page.context.close()
 

tests/sync/test_video.py

@@ -32,6 +32,7 @@ def test_should_expose_video_path(
     video = page.video
     assert video
     path = video.path()
+    assert isinstance(path, Path)
     assert repr(page.video) == f"<Video page={page}>"
     assert str(tmp_path) in str(path)
     page.wait_for_timeout(1000)