fix: preserve body option validation under python -O

Author: suraj-self

playwright/_impl/_fetch.py

@@ -396,7 +396,9 @@ async def _inner_fetch(
             + (1 if form is not None else 0)
             + (1 if multipart is not None else 0)
         ) > 1:
-            raise Error("Only one of 'data', 'form' or 'multipart' can be specified")
+            raise AssertionError(
+                "Only one of 'data', 'form' or 'multipart' can be specified"
+            )
         assert (
             maxRedirects is None or maxRedirects >= 0
         ), "'max_redirects' must be greater than or equal to '0'"

tests/async/test_fetch_global.py

@@ -16,7 +16,6 @@
 import base64
 import json
 import re
-import subprocess
 import sys
 from pathlib import Path
 from typing import Any, List
@@ -508,7 +507,7 @@ async def test_should_reject_empty_data_with_form(
 ) -> None:
     request = await playwright.request.new_context()
     with pytest.raises(
-        Error,
+        AssertionError,
         match="Only one of 'data', 'form' or 'multipart' can be specified",
     ):
         await request.post(
@@ -519,44 +518,6 @@ async def test_should_reject_empty_data_with_form(
     await request.dispose()
 
 
-async def test_should_reject_multiple_body_options_under_python_optimization(
-    server: Server,
-) -> None:
-    script = f"""
-import asyncio
-from playwright.async_api import async_playwright, Error
-
-async def main():
-    async with async_playwright() as p:
-        request = await p.request.new_context()
-        try:
-            await request.post(
-                "{server.EMPTY_PAGE}",
-                data="",
-                form={{"name": "value"}},
-            )
-        except Error as e:
-            expected = "Only one of 'data', 'form' or 'multipart' can be specified"
-            if expected not in str(e):
-                raise
-        else:
-            raise RuntimeError("Conflicting body options were accepted")
-        finally:
-            await request.dispose()
-
-asyncio.run(main())
-"""
-
-    result = subprocess.run(
-        [sys.executable, "-O", "-c", script],
-        capture_output=True,
-        text=True,
-        timeout=60,
-    )
-
-    assert result.returncode == 0, result.stdout + result.stderr
-
-
 async def test_should_retry_ECONNRESET(playwright: Playwright, server: Server) -> None:
     request_count = 0
 

tests/sync/test_fetch_global.py

@@ -14,8 +14,6 @@
 
 import json
 import re
-import subprocess
-import sys
 from pathlib import Path
 from typing import List
 from urllib.parse import urlparse
@@ -353,7 +351,7 @@ def test_should_reject_empty_data_with_form(
 ) -> None:
     request = playwright.request.new_context()
     with pytest.raises(
-        Error,
+        AssertionError,
         match="Only one of 'data', 'form' or 'multipart' can be specified",
     ):
         request.post(
@@ -364,40 +362,6 @@ def test_should_reject_empty_data_with_form(
     request.dispose()
 
 
-def test_should_reject_multiple_body_options_under_python_optimization(
-    server: Server,
-) -> None:
-    script = f"""
-from playwright.sync_api import sync_playwright, Error
-
-with sync_playwright() as p:
-    request = p.request.new_context()
-    try:
-        request.post(
-            "{server.EMPTY_PAGE}",
-            data="",
-            form={{"name": "value"}},
-        )
-    except Error as e:
-        expected = "Only one of 'data', 'form' or 'multipart' can be specified"
-        if expected not in str(e):
-            raise
-    else:
-        raise RuntimeError("Conflicting body options were accepted")
-    finally:
-        request.dispose()
-"""
-
-    result = subprocess.run(
-        [sys.executable, "-O", "-c", script],
-        capture_output=True,
-        text=True,
-        timeout=60,
-    )
-
-    assert result.returncode == 0, result.stdout + result.stderr
-
-
 def test_should_throw_when_fail_on_status_code_is_true(
     playwright: Playwright, server: Server
 ) -> None: