Skip to content

Commit a22bda2

Browse files
authored
chore(bots): name the agent workflows agent-*, and start tasks by hand only (#2043)
1 parent 4f9a57b commit a22bda2

5 files changed

Lines changed: 13 additions & 88 deletions

File tree

‎.claude/skills/playwright-triage/SKILL.md‎

Lines changed: 0 additions & 80 deletions
This file was deleted.
Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
1-
# Hands the issue to the Playwright bot when a maintainer applies agent-triage, agent-implement or
2-
# agent-task. Nothing else of the bot lives in this repo. Apply the label again to start another
3-
# run.
1+
# Hands the issue to the Playwright bot when a maintainer applies agent-triage or agent-implement.
2+
# Nothing else of the bot lives in this repo. Apply the label again to start another run.
43
name: "Agent: triage"
54

65
on:
@@ -15,8 +14,7 @@ jobs:
1514
if: >-
1615
github.repository_owner == 'microsoft' && (
1716
github.event.label.name == 'agent-triage' ||
18-
github.event.label.name == 'agent-implement' ||
19-
github.event.label.name == 'agent-task')
17+
github.event.label.name == 'agent-implement')
2018
runs-on: ubuntu-latest
2119
timeout-minutes: 5
2220
steps:

‎AGENTS.md‎

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,15 @@
11
# Playwright Java
22

3-
The Java client is a port of the JavaScript client in `../playwright/packages/playwright-core/src/client/`. When implementing or changing a method, read the corresponding JS file first and mirror its logic.
3+
The Java client is a port of the JavaScript client in `~/code/playwright/packages/playwright-core/src/client/`. When implementing or changing a method, read the corresponding JS file first and mirror its logic.
44

5-
Project checkouts (including the upstream `playwright` repo) live in the parent directory (`../`). Use the `gh` cli to interact with GitHub.
5+
Paths such as `~/code/playwright` in this file assume that you check the repos out in `~/code`. Use the `gh` cli to interact with GitHub.
6+
7+
## How this repo depends on Playwright
8+
9+
- **The driver.** The Java client talks to the Node.js driver that `microsoft/playwright` publishes: the `playwright-core` npm package, which `scripts/download_driver.sh` unpacks into `driver/src/main/resources/driver/package/`. `scripts/DRIVER_VERSION` names its version, and `npm view playwright@<version> gitHead` prints its upstream commit. Upstream `main` is close to it. Release `1.X.0` bundles the driver of `scripts/DRIVER_VERSION` at tag `v1.X.0`.
10+
- **Upstream code.** In `~/code/playwright`: the client in `packages/playwright-core/src/client/`, the API docs in `docs/src/api/`, the tests in `tests/page/` and `tests/library/`. Its `AGENTS.md` says how to build it and run a test.
11+
- **Where a bug is.** When the same calls fail in a Node.js test upstream too, the cause is in the driver or a browser, and the fix lands in `microsoft/playwright`. When Node.js passes, the bug is in the Java client: compare the `*Impl.java` with its JavaScript counterpart, and fix it here.
12+
- **The generated API.** `scripts/generate_api.sh` runs upstream's `utils/doclint/generateApiJson.js` at the commit of the driver, and `tools/api-generator` writes every interface and options class in `playwright/src/main/java/com/microsoft/playwright/`, `options/` and `assertions/`. Only `CLI.java`, `PlaywrightException.java`, `TimeoutError.java`, `assertions/PlaywrightAssertions.java` and the `package-info.java` files there are written by hand. Never edit a generated file: the next roll reverts it. A missing method or option is a change to `docs/src/api/` upstream.
613

714
## Build and test
815

@@ -72,4 +79,4 @@ Branch naming for issue fixes: `fix-<issue-number>`.
7279

7380
- **playwright-roll** (`.claude/skills/playwright-roll/SKILL.md`) — roll Playwright Java to a new upstream version: bump the driver, regenerate the API, and port relevant upstream changes.
7481
- **playwright-java-release** (`.claude/skills/playwright-java-release/SKILL.md`) — prepare a release after the rolling PR merges: cut the release branch, mark the Maven version, and draft the GitHub release.
75-
- **playwright-cherry-pick** (upstream, `../playwright/.claude/skills/playwright-cherry-pick/SKILL.md`) — cherry-pick a merged PR into a `release-1.X` branch as `cherry-pick(#<pr>): <original title>`. Use the same rules for this repo's release branches.
82+
- **playwright-cherry-pick** (upstream, `~/code/playwright/.claude/skills/playwright-cherry-pick/SKILL.md`) — cherry-pick a merged PR into a `release-1.X` branch as `cherry-pick(#<pr>): <original title>`. Use the same rules for this repo's release branches.

0 commit comments

Comments
 (0)