Skip to content

Commit d03ee41

Browse files
saschahauergregkh
authored andcommitted
gpio: pca953x: fix wrong error probe return value
commit 0a1db19 upstream. The second argument to dev_err_probe() is the error value. Pass the return value of devm_request_threaded_irq() there instead of the irq number. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> Fixes: c47f7ff ("gpio: pca953x: Utilise dev_err_probe() where it makes sense") Link: https://lore.kernel.org/r/20250616134503.1201138-1-s.hauer@pengutronix.de Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 5192f17 commit d03ee41

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/gpio/gpio-pca953x.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -989,7 +989,7 @@ static int pca953x_irq_setup(struct pca953x_chip *chip, int irq_base)
989989
IRQF_ONESHOT | IRQF_SHARED, dev_name(dev),
990990
chip);
991991
if (ret)
992-
return dev_err_probe(dev, client->irq, "failed to request irq\n");
992+
return dev_err_probe(dev, ret, "failed to request irq\n");
993993

994994
return 0;
995995
}

0 commit comments

Comments
 (0)