Skip to content

Commit afcd1a3

Browse files
Damenlygregkh
authored andcommitted
ocfs2: update inode fsync transaction id in ocfs2_unlink and ocfs2_link
[ Upstream commit 8c40984 ] transaction id should be updated in ocfs2_unlink and ocfs2_link. Otherwise, inode link will be wrong after journal replay even fsync was called before power failure: ======================================================================= $ touch testdir/bar $ ln testdir/bar testdir/bar_link $ fsync testdir/bar $ stat -c %h $SCRATCH_MNT/testdir/bar 1 $ stat -c %h $SCRATCH_MNT/testdir/bar 1 ======================================================================= Link: https://lkml.kernel.org/r/20240408082041.20925-4-glass.su@suse.com Fixes: ccd979b ("[PATCH] OCFS2: The Second Oracle Cluster Filesystem") Signed-off-by: Su Yue <glass.su@suse.com> Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com> Cc: Changwei Ge <gechangwei@live.cn> Cc: Gang He <ghe@suse.com> Cc: Joel Becker <jlbec@evilplan.org> Cc: Jun Piao <piaojun@huawei.com> Cc: Junxiao Bi <junxiao.bi@oracle.com> Cc: Mark Fasheh <mark@fasheh.com> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 10fc3a1 commit afcd1a3

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

fs/ocfs2/namei.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -797,6 +797,7 @@ static int ocfs2_link(struct dentry *old_dentry,
797797
ocfs2_set_links_count(fe, inode->i_nlink);
798798
fe->i_ctime = cpu_to_le64(inode_get_ctime_sec(inode));
799799
fe->i_ctime_nsec = cpu_to_le32(inode_get_ctime_nsec(inode));
800+
ocfs2_update_inode_fsync_trans(handle, inode, 0);
800801
ocfs2_journal_dirty(handle, fe_bh);
801802

802803
err = ocfs2_add_entry(handle, dentry, inode,
@@ -993,6 +994,7 @@ static int ocfs2_unlink(struct inode *dir,
993994
drop_nlink(inode);
994995
drop_nlink(inode);
995996
ocfs2_set_links_count(fe, inode->i_nlink);
997+
ocfs2_update_inode_fsync_trans(handle, inode, 0);
996998
ocfs2_journal_dirty(handle, fe_bh);
997999

9981000
inode_set_mtime_to_ts(dir, inode_set_ctime_current(dir));

0 commit comments

Comments
 (0)