Fix hpcg error (#539)

* fix hpcg error

* resolving unittests

Author: nmalkapuram

src/VirtualClient/VirtualClient.Actions.UnitTests/Hpcg/HpcgExecutorTests.cs

@@ -3,22 +3,26 @@
 
 namespace VirtualClient.Actions
 {
+    using Microsoft.Azure.Amqp.Framing;
+    using Microsoft.Extensions.DependencyInjection;
+    using Microsoft.VisualStudio.TestPlatform.PlatformAbstractions.Interfaces;
+    using Moq;
+    using Newtonsoft.Json;
+    using Newtonsoft.Json.Linq;
+    using NUnit.Framework;
     using System;
+    using System.Collections;
     using System.Collections.Generic;
     using System.Diagnostics;
     using System.IO;
     using System.Linq;
+    using System.Runtime.Intrinsics.X86;
     using System.Threading;
     using System.Threading.Tasks;
-    using Microsoft.Extensions.DependencyInjection;
-    using Moq;
-    using Newtonsoft.Json;
-    using Newtonsoft.Json.Linq;
-    using NUnit.Framework;
-    using VirtualClient.Contracts;
+    using VirtualClient.Common.Contracts;
     using VirtualClient.Common.Extensions;
     using VirtualClient.Common.Telemetry;
-    using VirtualClient.Common.Contracts;
+    using VirtualClient.Contracts;
 
     [TestFixture]
     [Category("Unit")]
@@ -176,8 +180,12 @@ public async Task HpcgExecutorWritesExpectedRunShellFile()
                 .Returns(false)
                 .Returns(true);
 
+
             string expectedFile = $". {this.mockFixture.GetPackagePath()}/JavaDevelopmentKit/share/spack/setup-env.sh" + Environment.NewLine
-                    + "spack install --reuse -n -y hpcg@9.8 %gcc +openmp ^openmpi@6.66.666" + Environment.NewLine
+                    + $"mkdir -p {this.mockFixture.GetPackagePath()}/JavaDevelopmentKit/opt/spack/.spack-db" + Environment.NewLine
+                    + $"sudo chown -R $(whoami):$(whoami) {this.mockFixture.GetPackagePath()}/JavaDevelopmentKit" + Environment.NewLine
+                    + $"chmod -R u+rwx {this.mockFixture.GetPackagePath()}/JavaDevelopmentKit" + Environment.NewLine
+                    + "spack install --reuse -n -y hpcg@9.8 %gcc ^openmpi@6.66.666" + Environment.NewLine
                     + $"spack load hpcg@9.8 %gcc ^openmpi@6.66.666" + Environment.NewLine
                     + $"mpirun --np 7 --use-hwthread-cpus --allow-run-as-root xhpcg";
 

src/VirtualClient/VirtualClient.Actions/HPCG/HpcgExecutor.cs

@@ -237,9 +237,14 @@ private async Task WriteHpcgRunShellAsync(CancellationToken cancellationToken)
                 // . spack/share/spack/setup-env.sh
                 string spackSetupCommand = $". {this.spackDirectory}/share/spack/setup-env.sh";
 
+                // Giving permissions to the required files
+                string createSpackDbDirCmd = $"mkdir -p {this.spackDirectory}/opt/spack/.spack-db";
+                string chownSpackDirCmd = $"sudo chown -R $(whoami):$(whoami) {this.spackDirectory}";
+                string chmodSpackDirCmd = $"chmod -R u+rwx {this.spackDirectory}";
+
                 // If gcc>= 9, use zen2. if <=8, use zen.
-                // spack install -n -y hpcg %gcc@10.3.0 +openmp target=zen2 ^openmpi@4.1.1
-                string installCommand = $"spack install --reuse -n -y hpcg@{this.HpcgVersion} %gcc +openmp ^openmpi@{this.OpenMpiVersion}";
+                // spack install -n -y hpcg %gcc@10.3.0 target=zen2 ^openmpi@4.1.1
+                string installCommand = $"spack install --reuse -n -y hpcg@{this.HpcgVersion} %gcc ^openmpi@{this.OpenMpiVersion}";
 
                 // spack load hpcg %gcc@10.3.0
                 string loadCommand = $"spack load hpcg@{this.HpcgVersion} %gcc ^openmpi@{this.OpenMpiVersion}";
@@ -249,7 +254,7 @@ private async Task WriteHpcgRunShellAsync(CancellationToken cancellationToken)
                 int coreCount = cpuInfo.PhysicalCoreCount;
                 string mpirunCommand = $"mpirun --np {coreCount} --use-hwthread-cpus --allow-run-as-root xhpcg";
 
-                this.runShellText = string.Join(Environment.NewLine, spackSetupCommand, installCommand, loadCommand, mpirunCommand);
+                this.runShellText = string.Join(Environment.NewLine, spackSetupCommand, createSpackDbDirCmd, chownSpackDirCmd, chmodSpackDirCmd, installCommand, loadCommand, mpirunCommand);
 
                 await this.systemManagement.FileSystem.File.WriteAllTextAsync(this.hpcgRunShellPath, this.runShellText, cancellationToken).ConfigureAwait(false);
             }