Inverted Boolean condition and swapped if-else branches. (#9)

ralph-lange · web-flow · commit 26ed5e2d9cf9 · 2020-06-30T10:31:55.000+02:00
Signed-off-by: Ralph Lange (CR/AEE1) &lt;ralph.lange@de.bosch.com&gt;
diff --git a/microros_olimex_e407_extensions/Src/allocators.c b/microros_olimex_e407_extensions/Src/allocators.c
@@ -25,11 +25,11 @@ void * __freertos_reallocate(void * pointer, size_t size, void * state){
   // printf("-- Realloc %d -> %d (prev: %d B)\n",getBlockSize(pointer),size, xPortGetFreeHeapSize());
   absoluteUsedMemory += size;
   usedMemory += size;
-  if (NULL != pointer){
+  if (NULL == pointer){
+    return pvPortMalloc(size);
+  } else {
     usedMemory -= getBlockSize(pointer);
     return pvPortRealloc(pointer,size);
-  } else {
-    return pvPortMalloc(size);
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -25,11 +25,11 @@ void * __freertos_reallocate(void * pointer, size_t size, void * state){`
`25`	`25`	`// printf("-- Realloc %d -> %d (prev: %d B)\n",getBlockSize(pointer),size, xPortGetFreeHeapSize());`
`26`	`26`	`absoluteUsedMemory += size;`
`27`	`27`	`usedMemory += size;`
`28`		`- if (NULL != pointer){`
	`28`	`+ if (NULL == pointer){`
	`29`	`+ return pvPortMalloc(size);`
	`30`	`+ } else {`
`29`	`31`	`usedMemory -= getBlockSize(pointer);`
`30`	`32`	`return pvPortRealloc(pointer,size);`
`31`		`- } else {`
`32`		`- return pvPortMalloc(size);`
`33`	`33`	`}`
`34`	`34`	`}`
`35`	`35`