diff --git a/components/github-actions-conventions/naming-lint.test.mjs b/components/github-actions-conventions/naming-lint.test.mjs index a6022754..d8d70254 100644 --- a/components/github-actions-conventions/naming-lint.test.mjs +++ b/components/github-actions-conventions/naming-lint.test.mjs @@ -237,9 +237,7 @@ test("slot names the pull request pipeline model relies on parse as stage plus f "pr-review-security", "pr-verify", "pr-explain", - "pr-address-feedback", - "pr-fix-ci", - "pr-update", + "pr-unblock", "pr-merge", "pr-automerge", "post-merge-verify", @@ -254,6 +252,9 @@ test("slot names the pull request pipeline model relies on parse as stage plus f modifier: "go", }); assert.equal(parseSlotName("pr-gatekeep", vocabulary).function, undefined); + for (const retired of ["pr-update", "pr-fix-ci", "pr-address-feedback"]) { + assert.equal(parseSlotName(retired, vocabulary).function, undefined, retired); + } }); test("activity names follow the grammar", () => { diff --git a/components/github-actions-conventions/vocabulary.json b/components/github-actions-conventions/vocabulary.json index 19315186..831f7025 100644 --- a/components/github-actions-conventions/vocabulary.json +++ b/components/github-actions-conventions/vocabulary.json @@ -23,11 +23,6 @@ "plan": [], "work": [{ "name": "respond-mention", "status": "in-use" }], "pr": [ - { - "name": "address-feedback", - "status": "reserved", - "purpose": "Respond to pull request review threads." - }, { "name": "audit-workflows", "status": "in-use" }, { "name": "automerge", "status": "in-use" }, { "name": "bump-plugin-version", "status": "in-use" }, @@ -38,7 +33,6 @@ "status": "reserved", "purpose": "Explain the pull request for human readers; runs alongside verify." }, - { "name": "fix-ci", "status": "reserved", "purpose": "Repair failing CI." }, { "name": "lint-dockerfile", "status": "in-use" }, { "name": "merge", "status": "reserved", "purpose": "Merge the pull request." }, { @@ -54,16 +48,7 @@ { "name": "run-checks", "status": "in-use" }, { "name": "scan-dependencies", "status": "in-use" }, { "name": "test-windows", "status": "in-use" }, - { - "name": "unblock", - "status": "reserved", - "purpose": "Assess a blocked pull request and take the action that unblocks it." - }, - { - "name": "update", - "status": "reserved", - "purpose": "Bring the pull request branch up to date." - }, + { "name": "unblock", "status": "in-use" }, { "name": "validate-onboard-catalog", "status": "in-use" }, { "name": "verify",