Skip to content

Commit 52d019d

Browse files
committed
release canaries: a project's commands do not see XLINGS_BIN
The canary job exported XLINGS_BIN, the released xlings that bootstraps mcpp, to every command of the project. xlings' test kit reads the name as the binary under test, so its tests drove the released xlings instead of the one they had just built. With xlings 2026.10.11.2, test_subos_new_template read an instance.json the released xlings does not write, and the canary blocked the 2026.10.11.1 tag. mcpp keeps its xlings through MCPP_VENDORED_XLINGS; the project's commands run without XLINGS_BIN.
1 parent 2083588 commit 52d019d

1 file changed

Lines changed: 7 additions & 0 deletions

File tree

‎.github/workflows/release-canaries.yml‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,13 @@ jobs:
8181
run: |
8282
export MCPP="$CANDIDATE"
8383
export MCPP_VENDORED_XLINGS="$XLINGS_BIN"
84+
# The project's commands do not see the name: mcpp has its xlings
85+
# above, and a project may give XLINGS_BIN its own meaning. xlings'
86+
# test kit reads it as the binary under test, so its tests drove the
87+
# released xlings instead of the one they had just built (2026.10.11.1:
88+
# test_subos_new_template read an instance.json the released xlings
89+
# does not write).
90+
unset XLINGS_BIN
8491
# The bash running this step, by path (release_canaries.py says why).
8592
if [ "$RUNNER_OS" = Windows ]; then
8693
export CANARY_BASH="$(cygpath -w "$BASH")"

0 commit comments

Comments
 (0)