Improve type hinting slightly

Author: oschwald

minfraud/validation.py

@@ -423,7 +423,7 @@ def _transaction_id(s: Optional[str]) -> str:
 )
 
 
-def _validate_at_least_one_identifier_field(report) -> bool:
+def _validate_at_least_one_identifier_field(report: dict) -> bool:
     optional_fields = ["ip_address", "maxmind_id", "minfraud_id", "transaction_id"]
     if not any(field in report for field in optional_fields):
         # We return MultipleInvalid instead of ValueError to be consistent with what
@@ -442,7 +442,7 @@ def _validate_at_least_one_identifier_field(report) -> bool:
     return True
 
 
-def validate_report(report) -> bool:
+def validate_report(report: dict) -> bool:
     """Validate minFraud Transaction Report fields."""
     _validate_report_schema(report)
     _validate_at_least_one_identifier_field(report)

tests/test_validation.py

@@ -2,7 +2,7 @@
 
 import unittest
 from decimal import Decimal
-from typing import Any
+from typing import Any, Callable
 
 from voluptuous import MultipleInvalid
 
@@ -33,7 +33,7 @@ def check_transaction_str_type(self, object: str, key: str) -> None:
         self.check_transaction({object: {key: "string"}})
         self.check_invalid_transaction({object: {key: 12}})
 
-    def check_positive_number(self, f) -> None:
+    def check_positive_number(self, f: Callable) -> None:
         for good in (1, 1.1, Decimal("1.1")):
             self.check_transaction(f(good))
         for bad in ("1.2", "1", -1, -1.1, 0):

tests/test_webservice.py

@@ -201,7 +201,7 @@ def test_missing_constructor_args(self) -> None:
             self.client_class(license_key="1234567890ab")  # type: ignore[call-arg]
 
         with self.assertRaises(TypeError):
-            self.client_class("47")  # type: ignore
+            self.client_class("47")  # type: ignore[arg-type,call-arg]
 
 
 class BaseTransactionTest(BaseTest):
@@ -385,7 +385,7 @@ def setUp(self) -> None:
         super().setUp()
 
     def tearDown(self) -> None:
-        self._loop.run_until_complete(self.client.close())  # type: ignore
+        self._loop.run_until_complete(self.client.close())  # type: ignore[attr-defined]
         self._loop.close()
         super().tearDown()