Merge pull request #111 from maxmind/greg/tox-linting

Use tox to run linters

Author: horgh

.github/workflows/lint.yml

@@ -5,6 +5,7 @@
 A client API to MaxMind's minFraud Score and Insights web services.
 """
 
+# flake8: noqa: F401
 from .errors import (
     MinFraudError,
     AuthenticationError,

minfraud/__init__.py

@@ -97,7 +97,7 @@ def maybe_hash_email(transaction):
     if at_idx == -1:
         return
 
-    domain = _clean_domain(address[at_idx + 1 :])
+    domain = _clean_domain(address[at_idx + 1 :]) # noqa
     local_part = address[:at_idx]
 
     if domain != "" and "domain" not in email:

minfraud/request.py

@@ -32,6 +32,7 @@
 
 _REQUEST_UA = f"minFraud-API/{__version__} {requests.utils.default_user_agent()}"
 
+
 # pylint: disable=too-many-instance-attributes, missing-class-docstring
 class BaseClient:
     _account_id: str
@@ -74,7 +75,8 @@ def _handle_success(
             decoded_body = json.loads(raw_body)
         except ValueError as ex:
             raise MinFraudError(
-                f"Received a 200 response but could not decode the response as JSON: {raw_body}",
+                "Received a 200 response but could not decode the "
+                f"response as JSON: {raw_body}",
                 200,
                 uri,
             ) from ex

minfraud/webservice.py

@@ -9,17 +9,40 @@ max-line-length = 88
 universal = 1
 
 [tox:tox]
-envlist = py36, py37, py38, py39, py310, mypy
+envlist = {py37,py38,py39,py310}-test,py310-{black,lint,flake8,mypy}
 
 [gh-actions]
 python =
     3.7: py37
     3.8: py38
     3.9: py39
-    "3.10": py310, mypy
+    "3.10": py310,black,lint,flake8,mypy
 
-[testenv]
+[testenv:{py37,py38,py39,py310}-test]
 deps =
-    pytest
     mocket
+    pytest
+
+    # explicitly require indirect dependency to fix build failure.
+    # This can be removed when aiohttp 3.9 is released.
+    charset-normalizer==2.1.1
 commands = pytest tests
+
+[testenv:py310-black]
+deps = black
+commands =  black --check --diff .
+
+[testenv:py310-lint]
+deps = pylint
+commands = pylint minfraud
+
+[testenv:py310-flake8]
+deps = flake8
+commands = flake8 minfraud
+
+[testenv:py310-mypy]
+deps =
+    mypy
+    types-requests
+    voluptuous-stubs
+commands = mypy minfraud tests