Merge pull request #112 from maxmind/greg/improved-message

horgh · web-flow · commit 33aab193e551 · 2020-10-14T07:42:35.000-07:00
Improve exception message
diff --git a/src/MaxMind/Db/Reader.php b/src/MaxMind/Db/Reader.php
@@ -215,7 +215,9 @@ private function findAddressInTree(string $ipAddress): array
             // Record is a data pointer
             return [$node, $i];
         }
-        throw new InvalidDatabaseException('Something bad happened');
+        throw new InvalidDatabaseException(
+            'Invalid or corrupt database. Maximum search depth reached without finding a leaf node'
+        );
     }
 
     private function ipV4StartNode(): int

Original file line number	Diff line number	Diff line change
`@@ -215,7 +215,9 @@ private function findAddressInTree(string $ipAddress): array`
`215`	`215`	`// Record is a data pointer`
`216`	`216`	`return [$node, $i];`
`217`	`217`	`}`
`218`		`- throw new InvalidDatabaseException('Something bad happened');`
	`218`	`+ throw new InvalidDatabaseException(`
	`219`	`+ 'Invalid or corrupt database. Maximum search depth reached without finding a leaf node'`
	`220`	`+ );`
`219`	`221`	`}`
`220`	`222`
`221`	`223`	`private function ipV4StartNode(): int`