fix(spiffeid): require spiffe:// prefix when parsing IDs (spiffe#398)

Signed-off-by: Max Lambrecht <maxlambrecht@gmail.com>

Author: maxlambrecht

java-spiffe-core/src/main/java/io/spiffe/spiffeid/SpiffeId.java

@@ -72,7 +72,7 @@ public static SpiffeId parse(final String id) {
             throw new IllegalArgumentException(EMPTY);
         }
 
-        if (!id.contains(SCHEME_PREFIX)) {
+        if (!id.startsWith(SCHEME_PREFIX)) {
             throw new InvalidSpiffeIdException(WRONG_SCHEME);
         }
 

java-spiffe-core/src/test/java/io/spiffe/spiffeid/SpiffeIdTest.java

@@ -98,7 +98,8 @@ static Stream<Arguments> provideInvalidSpiffeIds() {
                 Arguments.of("spiffe://trustdomain/./other", "Path cannot contain dot segments"),
                 Arguments.of("spiffe://trustdomain/../other", "Path cannot contain dot segments"),
                 Arguments.of("spiffe://trustdomain/", "Path cannot have a trailing slash"),
-                Arguments.of("spiffe://trustdomain/path/", "Path cannot have a trailing slash")
+                Arguments.of("spiffe://trustdomain/path/", "Path cannot have a trailing slash"),
+                Arguments.of("xspiffe://trustdomain/path", "Scheme is missing or invalid")
         );
     }