Expose response fields the models were dropping

Found by comparing live API responses with the deserialized objects:
- RealTimeCurrencyConversion.from_ read the key "from_", but the API
  sends "from", so it was always None; also add symbol
- PreviousCloseAgg.transactions (n)
- TickerDetails.round_lot
- EtfGlobalConstituent.constituent_rank
- LastQuoteOptionContractSnapshot.ask_exchange / bid_exchange

Two existing tests asserted the old values (from_=None, no transactions)
even though their fixtures carried the data; updated them.

Author: justinpolygon

massive/rest/models/aggs.py

@@ -107,6 +107,7 @@ class PreviousCloseAgg:
     timestamp: Optional[float] = None
     volume: Optional[float] = None
     vwap: Optional[float] = None
+    transactions: Optional[int] = None
 
     @staticmethod
     def from_dict(d):
@@ -119,6 +120,7 @@ def from_dict(d):
             d.get("t", None),
             d.get("v", None),
             d.get("vw", None),
+            d.get("n", None),
         )
 
 

massive/rest/models/etf_global.py

@@ -84,6 +84,7 @@ class EtfGlobalConstituent:
     asset_class: Optional[str] = None
     composite_ticker: Optional[str] = None
     constituent_name: Optional[str] = None
+    constituent_rank: Optional[int] = None
     constituent_ticker: Optional[str] = None
     country_of_exchange: Optional[str] = None
     currency_traded: Optional[str] = None
@@ -105,6 +106,7 @@ def from_dict(d):
             asset_class=d.get("asset_class"),
             composite_ticker=d.get("composite_ticker"),
             constituent_name=d.get("constituent_name"),
+            constituent_rank=d.get("constituent_rank"),
             constituent_ticker=d.get("constituent_ticker"),
             country_of_exchange=d.get("country_of_exchange"),
             currency_traded=d.get("currency_traded"),

massive/rest/models/quotes.py

@@ -103,13 +103,15 @@ class RealTimeCurrencyConversion:
     initial_amount: Optional[float] = None
     last: Optional[ForexQuote] = None
     to: Optional[str] = None
+    symbol: Optional[str] = None
 
     @staticmethod
     def from_dict(d):
         return RealTimeCurrencyConversion(
             converted=d.get("converted", None),
-            from_=d.get("from_", None),
+            from_=d.get("from", d.get("from_")),
             initial_amount=d.get("initialAmount", None),
             last=None if "last" not in d else ForexQuote.from_dict(d["last"]),
             to=d.get("to", None),
+            symbol=d.get("symbol"),
         )

massive/rest/models/snapshot.py

@@ -170,6 +170,8 @@ class LastQuoteOptionContractSnapshot:
     last_updated: Optional[int] = None
     midpoint: Optional[float] = None
     timeframe: Optional[str] = None
+    ask_exchange: Optional[int] = None
+    bid_exchange: Optional[int] = None
 
     @staticmethod
     def from_dict(d):

massive/rest/models/tickers.py

@@ -112,6 +112,7 @@ class TickerDetails:
     name: Optional[str] = None
     phone_number: Optional[str] = None
     primary_exchange: Optional[str] = None
+    round_lot: Optional[int] = None
     share_class_figi: Optional[str] = None
     share_class_shares_outstanding: Optional[int] = None
     sic_code: Optional[str] = None
@@ -147,6 +148,7 @@ def from_dict(d):
             name=d.get("name", None),
             phone_number=d.get("phone_number", None),
             primary_exchange=d.get("primary_exchange", None),
+            round_lot=d.get("round_lot", None),
             share_class_figi=d.get("share_class_figi", None),
             share_class_shares_outstanding=d.get(
                 "share_class_shares_outstanding", None

test_rest/test_aggs.py

@@ -108,6 +108,7 @@ def test_get_previous_close_agg(self):
                 timestamp=1651003200000,
                 volume=95595226.0,
                 vwap=158.6074,
+                transactions=899965,
             )
         ]
         self.assertEqual(aggs, expected)

test_rest/test_quotes.py

@@ -351,12 +351,13 @@ def test_get_real_time_currency_conversion(self):
         conversion = self.c.get_real_time_currency_conversion("AUD", "USD", 100, 2)
         expected = RealTimeCurrencyConversion(
             converted=69.31,
-            from_=None,
+            from_="AUD",
             initial_amount=100,
             last=ForexQuote(
                 ask=1.4436264, bid=1.4427932, exchange=48, timestamp=1652195426000
             ),
             to="USD",
+            symbol="USD/AUD",
         )
 
         self.assertEqual(conversion, expected)