stack: Change Signature.CreatedBy to be a stack

This is a stack when the race detector is enabled. It's somewhat
inconvenient when used normally, but on the other hand it makes
verification if one was present more clear.

Author: maruel

internal/htmlstack/data.go

@@ -214,7 +214,7 @@ document.addEventListener("DOMContentLoaded", ready);
     </h1>
     {{if $e.Locked}} <span class="locked">[locked]</span>
     {{- end -}}
-    {{- if $e.CreatedBy.Func.Complete}} <span class="created">Created by: {{template "RenderCall" $e.CreatedBy}}</span>
+    {{- if $e.CreatedBy.Calls}} <span class="created">Created by: {{template "RenderCall" index $e.CreatedBy.Calls 0}}</span>
     {{- end -}}
     {{template "RenderCalls" $e.Signature.Stack}}
   {{- end -}}

internal/htmlstack/goroutines.tpl

@@ -241,6 +241,27 @@ func TestSymbol(t *testing.T) {
 	}
 }
 
+func TestRace(t *testing.T) {
+	t.Parallel()
+	data := internaltest.PanicOutputs()["race"]
+	c, err := stack.ParseDump(bytes.NewReader(data), ioutil.Discard, true)
+	if err != nil {
+		t.Fatal(err)
+	}
+	if c != nil {
+		t.Fatal("unexpected context")
+	}
+	/*
+		if c.Goroutines != nil {
+			t.Fatal("unexpected context")
+		}
+		buckets := stack.Aggregate(c.Goroutines, stack.AnyPointer)
+		if err := Write(ioutil.Discard, buckets, false, false); err != nil {
+			t.Fatal(err)
+		}
+	*/
+}
+
 func BenchmarkWrite(b *testing.B) {
 	b.ReportAllocs()
 	c, err := stack.ParseDump(bytes.NewReader(internaltest.StaticPanicwebOutput()), ioutil.Discard, true)

internal/htmlstack/htmlstack_test.go

@@ -60,10 +60,10 @@ func (pf pathFormat) formatCall(c *stack.Call) string {
 }
 
 func (pf pathFormat) createdByString(s *stack.Signature) string {
-	if s.CreatedBy.Func.DirName == "" {
+	if len(s.CreatedBy.Calls) == 0 {
 		return ""
 	}
-	return s.CreatedBy.Func.DirName + "." + s.CreatedBy.Func.Name + " @ " + pf.formatCall(&s.CreatedBy)
+	return s.CreatedBy.Calls[0].Func.DirName + "." + s.CreatedBy.Calls[0].Func.Name + " @ " + pf.formatCall(&s.CreatedBy.Calls[0])
 }
 
 // calcLengths returns the maximum length of the source lines and package names.

internal/ui.go

@@ -62,8 +62,11 @@ func TestBucketHeader(t *testing.T) {
 	b := &stack.Bucket{
 		Signature: stack.Signature{
 			State: "chan receive",
-			CreatedBy: newCallLocal(
-				"main.mainImpl", stack.Args{}, "/home/user/go/src/github.com/foo/bar/baz.go", 74),
+			CreatedBy: stack.Stack{
+				Calls: []stack.Call{
+					newCallLocal("main.mainImpl", stack.Args{}, "/home/user/go/src/github.com/foo/bar/baz.go", 74),
+				},
+			},
 			SleepMax: 6,
 			SleepMin: 2,
 		},

internal/ui_test.go

@@ -96,11 +96,15 @@ func TestAggregateExactMatching(t *testing.T) {
 		{
 			Signature: Signature{
 				State: "chan receive",
-				CreatedBy: newCall(
-					"main.mainImpl",
-					Args{},
-					"/gopath/src/github.com/maruel/panicparse/stack/stack.go",
-					74),
+				CreatedBy: Stack{
+					Calls: []Call{
+						newCall(
+							"main.mainImpl",
+							Args{},
+							"/gopath/src/github.com/maruel/panicparse/stack/stack.go",
+							74),
+					},
+				},
 				Stack: Stack{
 					Calls: []Call{
 						newCall(

stack/bucket_test.go

@@ -479,7 +479,7 @@ func (s *scanningState) scan(line string) (string, error) {
 		return "", nil
 
 	case gotCreated:
-		if found, err := parseFile(&cur.CreatedBy, trimmed); err != nil {
+		if found, err := parseFile(&cur.CreatedBy.Calls[0], trimmed); err != nil {
 			return "", err
 		} else if !found {
 			return "", fmt.Errorf("expected a file after a created line, got: %q", trimmed)
@@ -489,7 +489,9 @@ func (s *scanningState) scan(line string) (string, error) {
 
 	case gotFileFunc:
 		if match := reCreated.FindStringSubmatch(trimmed); match != nil {
-			if err := cur.CreatedBy.Func.Init(match[1]); err != nil {
+			cur.CreatedBy.Calls = make([]Call, 1)
+			if err := cur.CreatedBy.Calls[0].Func.Init(match[1]); err != nil {
+				cur.CreatedBy.Calls = nil
 				return "", err
 			}
 			s.state = gotCreated
@@ -534,7 +536,9 @@ func (s *scanningState) scan(line string) (string, error) {
 			return "", nil
 		}
 		if match := reCreated.FindStringSubmatch(trimmed); match != nil {
-			if err := cur.CreatedBy.Func.Init(match[1]); err != nil {
+			cur.CreatedBy.Calls = make([]Call, 1)
+			if err := cur.CreatedBy.Calls[0].Func.Init(match[1]); err != nil {
+				cur.CreatedBy.Calls = nil
 				return "", err
 			}
 			s.state = gotCreated