Improve test code.

Author: Madeorsk

packages/ra-core/src/dataProvider/useCreate.spec.tsx

@@ -149,16 +149,12 @@ describe('useCreate', () => {
             create: jest.fn(() => Promise.resolve({ data: { id: 1 } } as any)),
         });
         let localCreate;
-        let settled = false;
+        const onSettled = jest.fn();
         const Dummy = () => {
             const [create] = useCreate(
                 'foo',
                 { data: { bar: 'baz' } },
-                {
-                    onSettled: () => {
-                        settled = true;
-                    },
-                }
+                { onSettled }
             );
             localCreate = create;
             return <span />;
@@ -171,7 +167,7 @@ describe('useCreate', () => {
         );
         localCreate('foo', { data: { foo: 456 } });
         await waitFor(() => {
-            expect(settled).toBe(true);
+            expect(onSettled).toHaveBeenCalled();
         });
     });
 

packages/ra-core/src/dataProvider/useDelete.spec.tsx

@@ -212,19 +212,15 @@ describe('useDelete', () => {
             delete: jest.fn(() => Promise.resolve({ data: { id: 1 } } as any)),
         });
         let localDeleteOne;
-        let settled = false;
+        const onSettled = jest.fn();
         const Dummy = () => {
             const [deleteOne] = useDelete(
                 'foo',
                 {
                     id: 1,
                     previousData: { id: 1, bar: 'bar' },
                 },
-                {
-                    onSettled: () => {
-                        settled = true;
-                    },
-                }
+                { onSettled }
             );
             localDeleteOne = deleteOne;
             return <span />;
@@ -240,7 +236,7 @@ describe('useDelete', () => {
             previousData: { foo: 456 },
         });
         await waitFor(() => {
-            expect(settled).toBe(true);
+            expect(onSettled).toHaveBeenCalled();
         });
     });
 

packages/ra-core/src/dataProvider/useDeleteMany.spec.tsx

@@ -153,16 +153,12 @@ describe('useDeleteMany', () => {
             deleteMany: jest.fn(() => Promise.resolve({ data: [1, 2] } as any)),
         });
         let localDeleteMany;
-        let settled = false;
+        const onSettled = jest.fn();
         const Dummy = () => {
             const [deleteMany] = useDeleteMany(
                 'foo',
                 { ids: [1, 2] },
-                {
-                    onSettled: () => {
-                        settled = true;
-                    },
-                }
+                { onSettled }
             );
             localDeleteMany = deleteMany;
             return <span />;
@@ -175,7 +171,7 @@ describe('useDeleteMany', () => {
         );
         localDeleteMany('foo', { ids: [3, 4] });
         await waitFor(() => {
-            expect(settled).toBe(true);
+            expect(onSettled).toHaveBeenCalled();
         });
     });